After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762619 - Meaning of "save as" button isn't clear
Meaning of "save as" button isn't clear
Status: RESOLVED FIXED
Product: gnome-logs
Classification: Other
Component: general
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-logs maintainer(s)
gnome-logs maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-02-24 15:36 UTC by Allan Day
Modified: 2016-02-25 09:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1023 bytes, patch)
2016-02-25 01:22 UTC, Jonathan Kang 		none Details | Review
Use document-save-symbolic instead of send-to (1.05 KB, patch)
2016-02-25 02:51 UTC, Jonathan Kang 		committed Details | Review

Description Allan Day 2016-02-24 15:36:37 UTC 
Logs has a new button that allows logs to be saved. This works with a button that has the send-to icon on it.

When I tried the new version of logs for the first time, I couldn't work out what the new button did, and I had to try it to find out.

One problem is that send-to doesn't use a familiar metaphor, particularly in this situation. Another is that you're not really sending the logs - you're saving them.

Possible fixes:

 1. Use document-save-symbolic instead of send-to
 2. Change to a label: "Save..." or "Export..."
Comment 1 Jonathan Kang 2016-02-25 01:11:34 UTC 
(In reply to Allan Day from comment #0)
> Possible fixes:
> 
>  1. Use document-save-symbolic instead of send-to
>  2. Change to a label: "Save..." or "Export..."

Thanks for the report.

I agree with the first fix. It's much better to use document-save-symbolic instead of send-to.

We have a tooltip-text "Export logs to a file", which is clear enough, in my opinion. So I think it's not necessary to change the tooltip-text.
Comment 2 Jonathan Kang 2016-02-25 01:22:28 UTC 
Created attachment 322320 [details] [review]
patch

Use document-save-symbolic instead of send-to as the image of output_button in GlEventToolBar.
Comment 3 Jonathan Kang 2016-02-25 02:51:31 UTC 
Created attachment 322322 [details] [review]
Use document-save-symbolic instead of send-to

Add bugzilla link to commit message
Comment 4 David King 2016-02-25 09:27:21 UTC 
Review of attachment 322322 [details] [review]:

Seems fine to me.
Comment 5 Jonathan Kang 2016-02-25 09:39:08 UTC 
Pushed to master as Commit 9509f266c5109b1a796c10fd03c09b28e92222f5