After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762526 - default C++ flags aren't correct on android
default C++ flags aren't correct on android
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
git master
Other Linux
: Normal normal
: 1.7.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-23 12:18 UTC by Matthew Waters (ystreet00)
Modified: 2016-02-24 11:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
android: add -fno-rtti and -fno-exceptions to the default CXX flags (1.03 KB, patch)
2016-02-23 12:19 UTC, Matthew Waters (ystreet00)
committed Details | Review
taglib: explicitly enable -frtti on android (917 bytes, patch)
2016-02-23 23:40 UTC, Matthew Waters (ystreet00)
committed Details | Review
soundtouch: explicitly enable -fexceptions on android (945 bytes, patch)
2016-02-24 00:01 UTC, Matthew Waters (ystreet00)
committed Details | Review

Description Matthew Waters (ystreet00) 2016-02-23 12:18:37 UTC
Currently, the C++ flags are a direct copy of the C flags however by default, Android builds with the following extra C++ flags, -fno-rtti and -fno-exceptions that are overridable with ndk-build by just adding -frrti or -fexceptions in one of many strategic places.

The question is how are we going to expose this properly.
Comment 1 Matthew Waters (ystreet00) 2016-02-23 12:19:35 UTC
Created attachment 321945 [details] [review]
android: add -fno-rtti and -fno-exceptions to the default CXX flags

This brings the defaults back in line with ndk-build.
Comment 2 Matthew Waters (ystreet00) 2016-02-23 23:32:42 UTC
And while performing a full-rebuild, taglib has failed due to its use of dynamic_cast.
Comment 3 Matthew Waters (ystreet00) 2016-02-23 23:40:30 UTC
Created attachment 322188 [details] [review]
taglib: explicitly enable -frtti on android
Comment 4 Matthew Waters (ystreet00) 2016-02-24 00:01:30 UTC
Created attachment 322194 [details] [review]
soundtouch: explicitly enable -fexceptions on android
Comment 5 Matthew Waters (ystreet00) 2016-02-24 10:38:34 UTC
A full rebuild compiled and executes tutorial-3 correctly.

commit 973905f6c0fcbb44da00de17524e51388907c14e
Author: Matthew Waters <matthew@centricular.com>
Date:   Tue Feb 23 22:48:08 2016 +1100

    android: add -fno-rtti and -fno-exceptions to the default CXXFLAGS
    
    This is the default in ndk-build unless explicitly overridden by the app and
    android system libraries seem to be built with these flags as well.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=762526

commit 31bbc288e82f41baf72b48117b65224b29a861f0
Author: Matthew Waters <matthew@centricular.com>
Date:   Wed Feb 24 10:57:51 2016 +1100

    soundtouch: explicitly enable -fexceptions on android
    
    The default now is to disable it in line with the NDK build system
    
    https://bugzilla.gnome.org/show_bug.cgi?id=762526

commit d2b9b56abe524776dd247af1083dfd5fcbf716fc
Author: Matthew Waters <matthew@centricular.com>
Date:   Wed Feb 24 10:36:54 2016 +1100

    taglib: explicitly enable -frtti on android
    
    The default now is to disable it in line with the NDK build system
    
    https://bugzilla.gnome.org/show_bug.cgi?id=762526