After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762507 - StEntry should not allow middle-click paste while uneditable
StEntry should not allow middle-click paste while uneditable
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: st
3.18.x
Other Linux
: Normal minor
: ---
Assigned To: Michael Catanzaro
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2016-02-23 02:58 UTC by Michael Catanzaro
Modified: 2016-02-23 12:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
st-entry: Disable middle-click-paste when entry is not editable (1.29 KB, patch)
2016-02-23 04:04 UTC, Michael Catanzaro
committed Details | Review

Description Michael Catanzaro 2016-02-23 02:58:47 UTC
A contender for the least-serious bug of the year award:

 * Lock the screen
 * Type some text into the password field
 * Right click -> Show Text
 * Right click again -> Copy
 * Click Unlock

Now, if you didn't type your password, the password entry will be non-editable for about three seconds. During that time, if you middle click on it, you can paste into the non-editable entry.

You should only be able to paste into editable entries.
Comment 1 Michael Catanzaro 2016-02-23 03:07:59 UTC
Regression from eaf184b5852825d49c85c683bd7bde96df02baf2
Comment 2 Michael Catanzaro 2016-02-23 04:04:56 UTC
Created attachment 321915 [details] [review]
st-entry: Disable middle-click-paste when entry is not editable

Should only allow pasting the primary selection when the entry is
editable.
Comment 3 Florian Müllner 2016-02-23 07:54:07 UTC
Review of attachment 321915 [details] [review]:

Yup
Comment 4 Michael Catanzaro 2016-02-23 12:50:45 UTC
Attachment 321915 [details] pushed as 5086681 - st-entry: Disable middle-click-paste when entry is not editable