GNOME Bugzilla – Bug 762481
There should be a way to set username for connections
Last modified: 2016-02-27 09:00:42 UTC
Connecting to at least ZNC (and presumably other bouncers too) fails with NetworkError if there is no username. I suggest just using the nickname as the username, because most users are not going to care about the setting at all and those who do probably are fine with either having username match nickname or changing it in GOA.
Created attachment 321887 [details] [review] Set the username to be the same as the nickname Connecting to ZNC fails with a NetworkError if username is not defined. Make the assumption that most users don't want to have a separate username from nickname.
Why doesn't https://cgit.freedesktop.org/telepathy/telepathy-idle/tree/src/idle-connection.c#n775 work in this case?
Oh, didn't know about that. I think it's more likely that the nickname matches the username than the system login doing that. At least that's my case.
Well, your patch claims to fix a bug when the username is undefined, but that should never be the case as tp-idle itself has a fallback in case. So if the username is indeed undefined as you claim, there's a bug in tp-idle that needs fixing. If not, then at least the commit message of your patch is wrong.
Created attachment 321904 [details] [review] Updated commit message.
Review of attachment 321904 [details] [review]: OK