After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762481 - There should be a way to set username for connections
There should be a way to set username for connections
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-22 19:18 UTC by Daniel Landau
Modified: 2016-02-27 09:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Set the username to be the same as the nickname (1.21 KB, patch)
2016-02-22 19:18 UTC, Daniel Landau 		none Details | Review
Updated commit message. (1.38 KB, patch)
2016-02-22 22:10 UTC, Daniel Landau 		committed Details | Review

Description Daniel Landau 2016-02-22 19:18:52 UTC 
Connecting to at least ZNC (and presumably other bouncers too) fails with NetworkError if there is no username. I suggest just using the nickname as the username, because most users are not going to care about the setting at all and those who do probably are fine with either having username match nickname or changing it in GOA.
Comment 1 Daniel Landau 2016-02-22 19:18:56 UTC 
Created attachment 321887 [details] [review]
Set the username to be the same as the nickname

Connecting to ZNC fails with a NetworkError if username is not defined.
Make the assumption that most users don't want to have a separate
username from nickname.
Comment 2 Florian Müllner 2016-02-22 19:22:44 UTC 
Why doesn't https://cgit.freedesktop.org/telepathy/telepathy-idle/tree/src/idle-connection.c#n775 work in this case?
Comment 3 Daniel Landau 2016-02-22 20:44:38 UTC 
Oh, didn't know about that. I think it's more likely that the nickname matches the username than the system login doing that. At least that's my case.
Comment 4 Florian Müllner 2016-02-22 21:58:51 UTC 
Well, your patch claims to fix a bug when the username is undefined, but that should never be the case as tp-idle itself has a fallback in case. So if the username is indeed undefined as you claim, there's a bug in tp-idle that needs fixing. If not, then at least the commit message of your patch is wrong.
Comment 5 Daniel Landau 2016-02-22 22:10:21 UTC 
Created attachment 321904 [details] [review]
Updated commit message.
Comment 6 Florian Müllner 2016-02-22 22:42:28 UTC 
Review of attachment 321904 [details] [review]:

OK