Created attachment 321867 [details] [review]
windowManager: Always check dimming when an attached modal opens/closes

We skip window animations while the overview is shown (and the window
group is hidden) to avoid unnecessary work. However when an attached
modal dialog is opened or closed, this involves checking whether the
parent window should be dimmed - skipping that test means that we can
simply fail to dim or undim a window altogether, so do that check
unconditionally.

Created attachment 321868 [details] [review]
windowManager: Only animate dimming changes when necessary

Now that we no longer skip dimming/undimming windows while showing
the overview, we can still save a bit of work by changing the dimming
without animation while the window is hidden.

Review of attachment 321867 [details] [review]:

::: js/ui/windowManager.js
@@ +1500,3 @@
+            let parent = window.get_transient_for();
+            this._checkDimming(parent, window);
+            actor._parentDestroyId = parent.connect('unmanaged',

If we don't animate, _destroyWindowDone doesn't get called so when the parent gets unmanaged this handler will run for a destroyed actor.

Review of attachment 321868 [details] [review]:

looks good

Created attachment 321883 [details] [review]
windowManager: Always check dimming when an attached modal opens/closes

Review of attachment 321883 [details] [review]:

looks fine

Attachment 321868 [details] pushed as d8960b3 - windowManager: Only animate dimming changes when necessary
Attachment 321883 [details] pushed as 4c29604 - windowManager: Always check dimming when an attached modal opens/closes