After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762460 - [PATCH] year view events added a day earlier in UTC+ timezones
[PATCH] year view events added a day earlier in UTC+ timezones
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: General
3.19.x
Other Linux
: Normal normal
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-22 14:32 UTC by Marinus Schraal
Modified: 2017-04-17 18:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
year view UTC+ event add fix (2.05 KB, patch)
2016-02-22 14:32 UTC, Marinus Schraal 		reviewed Details | Review

Description Marinus Schraal 2016-02-22 14:32:18 UTC 
Created attachment 321848 [details] [review]
year view UTC+ event add fix

Currently adding full-day events in year view are added a day earlier if one is in a UTC+ timezone.

The code in build_component_from_details transforms the given start & end date (both 00:00 midnight) to UTC midnight, however in any +UTC timezone this is the day before. It then re-adds the timezone offset to the UTC date, resulting in (UTC midnight - tz offset) in the users timezone.

I believe it should just keep to local time as default, with the timezone offset indicating offset from UTC (indicating timezone). Attached patch does so and works for me (+1 UTC). However I do not know how e_cal* expects it's date's to be delivered for internal use.
Comment 1 Georges Basile Stavracas Neto 2016-02-29 18:55:05 UTC 
Review of attachment 321848 [details] [review]:

This is already fixed in master, sorry for not checking your patch in time!