After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762444 - Don't check for C++ compiler
Don't check for C++ compiler
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2016-02-22 12:30 UTC by Bastien Nocera
Modified: 2017-01-24 13:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Remove C++ check (610 bytes, patch)
2017-01-17 13:30 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2016-02-22 12:30:36 UTC 
CXX      libgnome_shell_js_la-shell-js.lo
../libtool: line 1763: g++: command not found
Makefile:2180: recipe for target 'libgnome_shell_js_la-shell-js.lo' failed
make[4]: *** [libgnome_shell_js_la-shell-js.lo] Error 1
make[4]: *** Waiting for unfinished jobs....

Because libtool will use the C++ compiler to link the JavaScript library to the engine, we should check for it in configure.ac.

This is likely an easy fix.
Comment 1 Bastien Nocera 2017-01-17 13:29:04 UTC 
The reverse is now true. It checks for C++ but doesn't use it. Will attach a patch.
Comment 2 Bastien Nocera 2017-01-17 13:30:35 UTC 
Created attachment 343647 [details] [review]
build: Remove C++ check

As it's not used any more.
Comment 3 Rui Matos 2017-01-24 13:08:02 UTC 
Review of attachment 343647 [details] [review]:

Might be good to point out that the last bit of c++ code was removed in commit ed99bef45841c407683cd7d353f0e2d364977261 .
Comment 4 Bastien Nocera 2017-01-24 13:18:41 UTC 
Added a reference to the last commit using C++, thanks.

Attachment 343647 [details] pushed as 7784bc0 - build: Remove C++ check