After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762407 - 3.19.90: core/startup-notification.c:418:15: error: format '%ld' expects argument of type 'long int', but argument 3 has type 'gint64 {aka long long int}' [-Werror=format=]
3.19.90: core/startup-notification.c:418:15: error: format '%ld' expects argu...
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2016-02-21 17:18 UTC by Olav Vitters
Modified: 2016-07-04 20:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix gint64 format (4.96 KB, patch)
2016-06-06 10:49 UTC, Luca Bruno
committed Details | Review

Description Olav Vitters 2016-02-21 17:18:05 UTC
http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20160221081357.tv.duvel.29570/log/mutter-3.19.90-1.mga6/build.0.20160221082846.log

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -DCLUTTER_ENABLE_COMPOSITOR_API -DCLUTTER_ENABLE_EXPERIMENTAL_API -DCOGL_ENABLE_EXPERIMENTAL_API -DCOGL_ENABLE_EXPERIMENTAL_2_0_API -DCLUTTER_DISABLE_DEPRECATION_WARNINGS -DCOGL_DISABLE_DEPRECATION_WARNINGS -pthread -D_REENTRANT -pthread -I/usr/include/clutter-1.0 -I/usr/include/cogl -I/usr/include/json-glib-1.0 -I/usr/include/cogl -I/usr/include/libupower-glib -I/usr/include/gnome-desktop-3.0 -I/usr/include/startup-notification-1.0 -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libxml2 -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libdrm -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/gobject-introspection-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gsettings-desktop-schemas -pthread -D_REENTRANT -I/usr/include/clutter-1.0 -I/usr/include/cogl -I/usr/include/atk-1.0 -I/usr/include/cogl -I/usr/include/json-glib-1.0 -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libxml2 -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/gudev-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I. -I. -I./backends -I./core -I./ui -I./compositor -DMUTTER_LIBEXECDIR=\"/usr/libexec\" -DMUTTER_LOCALEDIR=\"/usr/share/locale\" -DMUTTER_PKGDATADIR=\"/usr/share/mutter\" -DMUTTER_DATADIR=\"/usr/share\" -DG_LOG_DOMAIN=\"mutter\" -DSN_API_NOT_YET_FROZEN=1 -DMUTTER_PKGLIBDIR=\"/usr/lib/mutter\" -DMUTTER_PLUGIN_DIR=\"/usr/lib/mutter/plugins\" -DGETTEXT_PACKAGE=\"mutter\" -DXWAYLAND_PATH=\"/usr/bin/Xwayland\" -Wno-error=sign-compare -Wall -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wsign-compare -Werror -Wno-error=deprecated-declarations -MT core/startup-notification.lo -MD -MP -MF core/.deps/startup-notification.Tpo -c core/startup-notification.c  -fPIC -DPIC -o core/.libs/startup-notification.o
core/startup-notification.c: In function 'collect_timed_out_foreach':
core/startup-notification.c:418:15: error: format '%ld' expects argument of type 'long int', but argument 3 has type 'gint64 {aka long long int}' [-Werror=format=]
               "Sequence used %ld ms vs. %d max: %s\n",
               ^
cc1: all warnings being treated as errors
Makefile:1768: recipe for target 'core/startup-notification.lo' failed
make[4]: *** [core/startup-notification.lo] Error 1
make[4]: Leaving directory '/home/iurt/rpmbuild/BUILD/mutter-3.19.90/src'
Comment 1 Luca Bruno 2016-06-06 10:49:41 UTC
Created attachment 329181 [details] [review]
fix gint64 format

Simple patch attached. The only way I found to make it build correctly is to use the glib macro.
Comment 2 Simon McVittie 2016-06-30 21:51:14 UTC
Review of attachment 329181 [details] [review]:

I am not a Mutter maintainer, but this looks correct to me.
Comment 3 Jonas Ådahl 2016-07-01 02:15:23 UTC
Review of attachment 329181 [details] [review]:

Same here.
Comment 4 Olav Vitters 2016-07-04 20:36:55 UTC
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.