After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762400 - "JS ERROR: TypeError: this.place is null" when doing "What's here?" over the ocean.
"JS ERROR: TypeError: this.place is null" when doing "What's here?" over the ...
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2016-02-21 13:33 UTC by Hashem Nasarat
Modified: 2016-02-21 16:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
contextMenu: Handle nothing found in reverse geocode (1.01 KB, patch)
2016-02-21 14:52 UTC, Jonas Danielsson 		committed Details | Review
cast of nothing found on whats here (476.01 KB, video/webm)
2016-02-21 14:54 UTC, Jonas Danielsson 		  Details

Description Hashem Nasarat 2016-02-21 13:33:25 UTC 
(gnome-maps:20358): Gjs-WARNING **: JS ERROR: TypeError: this.place is null
MapMarker<._init@resource:///org/gnome/Maps/js/mapMarker.js:56
wrapper@resource:///org/gnome/gjs/modules/lang.js:178
_parent@resource:///org/gnome/gjs/modules/lang.js:131
PlaceMarker<._init@resource:///org/gnome/Maps/js/placeMarker.js:32
wrapper@resource:///org/gnome/gjs/modules/lang.js:178
MapView<.showPlace@resource:///org/gnome/Maps/js/mapView.js:461
wrapper@resource:///org/gnome/gjs/modules/lang.js:178
ContextMenu<._onWhatsHereActivated/<@resource:///org/gnome/Maps/js/contextMenu.js:127
GeocodeService<.reverse/<@resource:///org/gnome/Maps/js/geocodeService.js:81
main@resource:///org/gnome/Maps/js/main.js:47
run@resource:///org/gnome/gjs/modules/package.js:192
start@resource:///org/gnome/gjs/modules/package.js:176
@/home/hashem/sources/gnome-install/bin/gnome-maps:5

At the very least we should expect null to be returned and handle it accordingly (perhaps with a Utils.debug invocation).
Comment 1 Jonas Danielsson 2016-02-21 14:52:53 UTC 
Created attachment 321776 [details] [review]
contextMenu: Handle nothing found in reverse geocode
Comment 2 Jonas Danielsson 2016-02-21 14:54:15 UTC 
Created attachment 321777 [details]
cast of nothing found on whats here

Maybe something like this?
Comment 3 Hashem Nasarat 2016-02-21 15:02:14 UTC 
Review of attachment 321776 [details] [review]:

Looks great!
Comment 4 Jonas Danielsson 2016-02-21 16:04:04 UTC 
Attachment 321776 [details] pushed as 8eafb1f - contextMenu: Handle nothing found in reverse geocode