After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762328 - vaapidecoder_h264: assumes buffers have a single NAL
vaapidecoder_h264: assumes buffers have a single NAL
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
git master
Other Linux
: Normal critical
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-19 14:33 UTC by Thiago Sousa Santos
Modified: 2016-02-22 16:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vaapidecoder_h264: fix parsing of NALU aligned data (1.31 KB, patch)
2016-02-19 14:34 UTC, Thiago Sousa Santos 		committed Details | Review
vaapidecoder_h265: fix parsing of NALU aligned data (1.32 KB, patch)
2016-02-19 22:06 UTC, Thiago Sousa Santos 		committed Details | Review

Description Thiago Sousa Santos 2016-02-19 14:33:34 UTC 
When receiving alignment=nal input it assumes there is a single NAL per buffer, it might not always be true and causes lots of data to be ignored.
Comment 1 Thiago Sousa Santos 2016-02-19 14:34:05 UTC 
Created attachment 321663 [details] [review]
vaapidecoder_h264: fix parsing of NALU aligned data

Don't assume the whole buffer is a single NAL, instead look for the
next start code in case there are multiple NALs per buffer.
Comment 2 Víctor Manuel Jáquez Leal 2016-02-19 14:47:36 UTC 
would we do the same in HEVC decoder?
Comment 3 Thiago Sousa Santos 2016-02-19 20:25:33 UTC 
(In reply to Víctor Manuel Jáquez Leal from comment #2)
> would we do the same in HEVC decoder?

Yes, I think this patch should be replicated there.
Comment 4 Thiago Sousa Santos 2016-02-19 22:06:33 UTC 
Created attachment 321699 [details] [review]
vaapidecoder_h265: fix parsing of NALU aligned data

Same patch for HEVC. I didn't test this one as I don't have any mpegts
streams using HEVC but the fix is exactly the same as the one for H.264
Comment 5 Víctor Manuel Jáquez Leal 2016-02-22 16:42:40 UTC 
[# Bug 762328 - vaapidecoder_h264: assumes buffers have a single NAL - NEW

Attachment 321663 [details] pushed as 056a69c - vaapidecoder_h264: fix parsing of NALU aligned data
Attachment 321699 [details] pushed as 1f71503 - vaapidecoder_h265: fix parsing of NALU aligned data