After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762263 - terminal: use theme background for vte background
terminal: use theme background for vte background
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-18 12:55 UTC by Carlos Soriano
Modified: 2016-02-19 22:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
terminal: use theme background for vte background (1.61 KB, patch)
2016-02-18 12:55 UTC, Carlos Soriano 		committed Details | Review

Description Carlos Soriano 2016-02-18 12:55:39 UTC 
.
Comment 1 Carlos Soriano 2016-02-18 12:55:43 UTC 
Created attachment 321583 [details] [review]
terminal: use theme background for vte background

The widget didn't have any background set, which makes the terminal
have a white background in any theme.

That's a problem when using the dark variant of builder for example.

Fix that applying a style class to the terminal widget, so we can peek
correctly the background color in order to set it manually to the
vte widget.
Comment 2 Christian Hergert 2016-02-18 19:16:53 UTC 
Review of attachment 321583 [details] [review]:

Thanks! LGTM
Comment 3 Christian Hergert 2016-02-19 22:07:56 UTC 
Pushed with a followup commit to move the style into a shared.css bundled in the terminal plugin.

Thanks for tracking this down!

Attachment 321583 [details] pushed as b89855d - terminal: use theme background for vte background