After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 762142 - dashdemux: tests: use g_object_unref for test data
dashdemux: tests: use g_object_unref for test data
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-16 13:57 UTC by Florin Apostol
Modified: 2016-03-31 21:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (3.03 KB, patch)
2016-02-16 13:58 UTC, Florin Apostol 		committed Details | Review

Description Florin Apostol 2016-02-16 13:57:08 UTC 
The GstDashDemuxTestCase object is allocated using g_object_newv
but in many places was being deallocated using gst_object_unref.
This was caused by commit ae3ed25025e34ea9b09df59d22d7ebd7294560bc.
Comment 1 Florin Apostol 2016-02-16 13:58:14 UTC 
Created attachment 321374 [details] [review]
proposed patch
Comment 2 Thiago Sousa Santos 2016-03-31 21:29:22 UTC 
commit 8b777669f5c5030a9115d7da6a7a8ae144b415b8
Author: Thiago Santos <thiagoss@osg.samsung.com>
Date:   Thu Mar 31 18:23:22 2016 -0300

    tests: mssdemux: do not use gst_object_unref for pure GObject*
    
    Deallocate GObject* with g_object_unref instead of gst_object_unref.
    
    Even if it works now, it is confusing and in the future it might
    not work if any GstObject specifics are added.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=762142

commit 6efda0405948ab0d48b6d3962054725076580787
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Tue Feb 16 13:55:54 2016 +0000

    dashdemux: tests: use g_object_unref for test data
    
    The GstDashDemuxTestCase object is allocated using g_object_newv
    but in many places was being deallocated using gst_object_unref.
    This was caused by commit ae3ed25025e34ea9b09df59d22d7ebd7294560bc.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=762142