After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761914 - gstharness: always set our test-clock on the harnessed element
gstharness: always set our test-clock on the harnessed element
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal enhancement
: 1.7.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 761910
Blocks: 755999
 
 
Reported: 2016-02-12 10:31 UTC by Håvard Graff (hgr)
Modified: 2016-02-15 10:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (2.89 KB, patch)
2016-02-12 10:31 UTC, Håvard Graff (hgr)
none Details | Review
updated patch (2.89 KB, patch)
2016-02-12 12:23 UTC, Håvard Graff (hgr)
none Details | Review
updated patch (2.89 KB, patch)
2016-02-12 14:07 UTC, Håvard Graff (hgr)
none Details | Review
updated patch (2.90 KB, patch)
2016-02-13 19:59 UTC, Håvard Graff (hgr)
committed Details | Review

Description Håvard Graff (hgr) 2016-02-12 10:31:29 UTC
Created attachment 320951 [details] [review]
patch

The integration is already so tight, there is no reason to
not further formalize it!

An element will always get a clock set on it in a "normal" context from the parent pipeline, and we found that in the tests where we don't care about the clock, the testclock does not get in the way, and in all the tests where we *do* want a clock, we will save the extra line of code to set it on the element.

Not explicitly wanting a clock to be able to test no-clock scenarios is the more unusual case, and to then have to explicitly do things like gst_element_set_clock (element, NULL) makes this more explicit and better.

There are also some cases where you want to use the systemclock (stress-tests or not bothering with determinism), and this then will need a call to gst_harness_use_systemclock() which is fair.
Comment 1 Håvard Graff (hgr) 2016-02-12 12:23:17 UTC
Created attachment 320969 [details] [review]
updated patch
Comment 2 Håvard Graff (hgr) 2016-02-12 14:07:47 UTC
Created attachment 320981 [details] [review]
updated patch
Comment 3 Tim-Philipp Müller 2016-02-13 16:17:15 UTC
Comment on attachment 320981 [details] [review]
updated patch

Does not apply any more.
Comment 4 Håvard Graff (hgr) 2016-02-13 19:59:37 UTC
Created attachment 321081 [details] [review]
updated patch
Comment 5 Tim-Philipp Müller 2016-02-15 10:24:31 UTC
commit 69f5d287184328bebe8f2457cef4f4780cce6d6a
Author: Havard Graff <havard.graff@gmail.com>
Date:   Wed Jan 27 15:16:03 2016 +0100

    harness: always set our test-clock on the harnessed element
    
    The integration is already so tight, there is no reason to
    not further formalize it!
    
    https://bugzilla.gnome.org/show_bug.cgi?id=761914