After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761910 - gstharness: Fix MT issues when forwarding event/query to sink harness
gstharness: Fix MT issues when forwarding event/query to sink harness
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal normal
: 1.7.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 761932
Blocks: 761914
 
 
Reported: 2016-02-12 10:18 UTC by Håvard Graff (hgr)
Modified: 2016-02-13 16:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
test and fix (6.53 KB, patch)
2016-02-12 10:18 UTC, Håvard Graff (hgr) 		none Details | Review
updated patch (6.53 KB, patch)
2016-02-12 12:21 UTC, Håvard Graff (hgr) 		none Details | Review
updated patch (6.43 KB, patch)
2016-02-12 14:07 UTC, Håvard Graff (hgr) 		committed Details | Review

Description Håvard Graff (hgr) 2016-02-12 10:18:20 UTC 
Created attachment 320947 [details] [review]
test and fix

With test that demonstrates the problem
Comment 1 Håvard Graff (hgr) 2016-02-12 12:21:43 UTC 
Created attachment 320968 [details] [review]
updated patch
Comment 2 Håvard Graff (hgr) 2016-02-12 14:07:21 UTC 
Created attachment 320980 [details] [review]
updated patch
Comment 3 Tim-Philipp Müller 2016-02-13 16:09:46 UTC 
Pushed after fixing up:

gstharness.c: In function 'gst_harness_sink_event':
gstharness.c:255:5: error: 'ret' undeclared (first use in this function)
     ret = gst_pad_push_event (fwdpad, event);

commit 336c7bb69c1927ee669f4da5d3992481b598ad0e
Author: Stian Selnes <stian@pexip.com>
Date:   Thu Jan 21 13:33:15 2016 +0100

    harness: Fix MT issues when forwarding event/query to sink harness
    
    https://bugzilla.gnome.org/show_bug.cgi?id=761910
Comment 4 Tim-Philipp Müller 2016-02-13 16:15:13 UTC 
Actually I failed to git commit --amend:

commit aafa79e281843800477f3dba37a98f14264910fd
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Sat Feb 13 16:10:27 2016 +0000

    harness: fix compilation
    
    Was supposed to be squashed with 336c7bb6
    
    https://bugzilla.gnome.org/show_bug.cgi?id=761910

commit 39d3c06b18b705259c3d5a06669aa45e37dacff6
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Sat Feb 13 16:10:11 2016 +0000

    harness: fix indentation