After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761890 - in search clicking artist view returns you to main view
in search clicking artist view returns you to main view
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2016-02-12 00:23 UTC by Marinus Schraal
Modified: 2016-03-04 12:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Check if visible child is ArtistsAlbumsWidget on search toggle (1.39 KB, patch)
2016-02-28 00:34 UTC, Gaurav Narula 		committed Details | Review

Description Marinus Schraal 2016-02-12 00:23:34 UTC 
I noticed that while in search results clicking anything in the artist section will revert you back to the main view, after that search is pretty much broken.

Bisected it to this commit : https://git.gnome.org/browse/gnome-music/commit/?id=be592822e9f5e628bcd3ffced3a999d3cebcc5a4
Comment 1 Gaurav Narula 2016-02-28 00:34:27 UTC 
Created attachment 322559 [details] [review]
Check if visible child is ArtistsAlbumsWidget on search toggle

If a search is made from the Albums view, clicking on the artist result reverts back to the Albums view again. This patch adds a condition to check if the visible child of the current view is a ArtistsAlbumsWidget and does not switch to the Albums view if so.
Comment 2 Felipe Borges 2016-03-04 12:04:14 UTC 
Review of attachment 322559 [details] [review]:

When I click on an artist in the search results, it presents me the artist view without the sidebar. 

I guess it would be better to have the sidebar, and select and show the proper artist.

Any opinion, aday?