After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761812 - netclientclock: Only use observations with a RTT smaller than the median
netclientclock: Only use observations with a RTT smaller than the median
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 774916
Blocks:
 
 
Reported: 2016-02-10 10:51 UTC by Sebastian Dröge (slomo)
Modified: 2018-11-03 12:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
WIP: netclientclock: Only use observations with a RTT smaller than the median (24.50 KB, patch)
2016-02-10 10:51 UTC, Sebastian Dröge (slomo)
needs-work Details | Review

Description Sebastian Dröge (slomo) 2016-02-10 10:51:08 UTC
See commit message
Comment 1 Sebastian Dröge (slomo) 2016-02-10 10:51:25 UTC
Created attachment 320778 [details] [review]
WIP: netclientclock: Only use observations with a RTT smaller than the median

The idea is that observations with lower RTT are more accurate.

Use a sliding window of 64 observations but only take those for the linear
regression that have a RTT smaller than the median. This hopefully simplifies
this code a lot while at the same time improving the clock accuracy.

Previously we had complicated filtering logic that was based on a running
average RTT, median of the last 9 observations and discontinuity checking for
the applied observations. This should be unnecessary now.

This needs careful testing under various scenarios.
Comment 2 Sebastian Dröge (slomo) 2016-02-16 08:53:26 UTC
It might also make sense to split the window in two or three parts, and take the below-median delays of those 2/3 bins then. That way we will always consider measurements over a longer time, instead of possibly just from the beginning or end of the window.
Comment 3 Tim-Philipp Müller 2016-11-11 19:19:47 UTC
What's up with this?
Comment 4 Sebastian Dröge (slomo) 2016-11-12 08:25:37 UTC
Comment on attachment 320778 [details] [review]
WIP: netclientclock: Only use observations with a RTT smaller than the median

It was better in some cases, worse in others. Definitely needs more work and proper analysis.
Comment 5 GStreamer system administrator 2018-11-03 12:32:53 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/155.