After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761805 - Shortcuts: Standardize help overlay shortcuts/menu
Shortcuts: Standardize help overlay shortcuts/menu
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2016-02-10 06:41 UTC by Hashem Nasarat
Modified: 2016-02-10 08:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Shortcuts: Standardize help overlay shortcuts/menu (2.26 KB, patch)
2016-02-10 06:41 UTC, Hashem Nasarat
committed Details | Review

Description Hashem Nasarat 2016-02-10 06:41:53 UTC
There were some small but odd differences in maps' implementation of the help
overlay as compared to, e.g., nautilus, clocks, and evince.
Comment 1 Hashem Nasarat 2016-02-10 06:41:56 UTC
Created attachment 320773 [details] [review]
Shortcuts: Standardize help overlay shortcuts/menu

* Use standard Ctrl+F1 to open the shortcuts help overlay: at some point
  we'll use F1 to open the normal help documentation.
* Put the App Menu entry in the Help/About/Quit section
Comment 2 Jonas Danielsson 2016-02-10 08:12:56 UTC
Review of attachment 320773 [details] [review]:

Thanks Hashem!

I read this at:
https://wiki.gnome.org/Initiatives/GnomeGoals/ShortcutWindows

"Don't forget to include the shortcuts for raising the shortcuts window: Ctrl+? and Ctrl+F1."
Should we also have Ctrl+?

::: data/ui/app-menu.ui
@@ +11,3 @@
       <item>
+        <attribute name="label" translatable="yes">_Keyboard Shortcuts</attribute>
+        <attribute name="action">win.show-help-overlay</attribute>

So we do not need to add the accel? Does it get <Primary>F1 automatically? How about <Primary>? ?
Comment 3 Hashem Nasarat 2016-02-10 08:19:34 UTC
Review of attachment 320773 [details] [review]:

Shall I push this?

::: data/ui/app-menu.ui
@@ +11,3 @@
       <item>
+        <attribute name="label" translatable="yes">_Keyboard Shortcuts</attribute>
+        <attribute name="action">win.show-help-overlay</attribute>

Gtk automatically sets Ctrl + ? and Ctrl + F1.  :D
Comment 4 Jonas Danielsson 2016-02-10 08:21:01 UTC
Review of attachment 320773 [details] [review]:

Push it!
Comment 5 Hashem Nasarat 2016-02-10 08:30:41 UTC
Attachment 320773 [details] pushed as 6b1952e - Shortcuts: Standardize help overlay shortcuts/menu