After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761464 - Move the dhcp-timeout property to generic NMSettingIPConfig
Move the dhcp-timeout property to generic NMSettingIPConfig
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-1-2
 
 
Reported: 2016-02-02 16:17 UTC by Beniamino Galvani
Modified: 2016-02-16 10:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] dhcp: add support for configuring DHCPv6 timeout (10.51 KB, patch)
2016-02-16 10:52 UTC, Beniamino Galvani 		none Details | Review

Description Beniamino Galvani 2016-02-02 16:17:10 UTC 
The property makes sense for both IPv4 and IPv6 and so probably it should not be in NMSettingIP4Config but in the base object. We should fix this before NM 1.2.
Comment 1 Beniamino Galvani 2016-02-05 07:58:58 UTC 
Pushed branch bg/dhcp-timeout-property-bgo761464.
Comment 2 Thomas Haller 2016-02-13 13:59:53 UTC 
there is also nm_setting_ip4_config_get_dhcp_timeout in libnm-util. But we don't care, right?




Pushed a fixup, otherwise LGTM.



We should get this ABI break done before beta2
Comment 3 Beniamino Galvani 2016-02-16 10:52:06 UTC 
Created attachment 321358 [details] [review]
[PATCH] dhcp: add support for configuring DHCPv6 timeout

Lubomir had some concerns about the usefulness of dhcp-timeout property for IPv6, so I dropped that patch (attached in case we change our mind in the future). Merged the rest as:

https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=3ac6769e60d2c0fb88421cea199292e6279e40e0