After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761451 - gcc: filenames from error format strings contain invalid single quotation
gcc: filenames from error format strings contain invalid single quotation
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: plugins
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-02-02 11:20 UTC by Christian Hergert
Modified: 2016-02-15 21:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Improved GCC error format string regex (861 bytes, patch)
2016-02-15 18:35 UTC, sadath.anwar17 		reviewed Details | Review

Description Christian Hergert 2016-02-02 11:20:02 UTC 
Sometimes the files that are extracted when building, using our gcc plugin do not parse the filename correctly.

They contain an extra ' somewhere in the filename.

We need to improve our GCC error format string regex.

See plugins/gcc/gbp-gcc-build-result-addin.c:26 for the current regex (ERROR_FORMAT_REGEX).
Comment 1 sadath.anwar17 2016-02-15 18:35:33 UTC 
Created attachment 321286 [details] [review]
Improved GCC error format string regex
Comment 2 Christian Hergert 2016-02-15 21:50:16 UTC 
Review of attachment 321286 [details] [review]:

This doesn't seem to work for me.
Comment 3 Christian Hergert 2016-02-15 21:51:09 UTC 
It turns out this was not a problem in the regex filename extraction, but in our tracking of the current build directory from make.

I pushed a fix in commit 39ddfe40e269ec623659e2a09e98dc924db79e72 which turned out to be a bit more involved than I expected.