After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761285 - [review, nm-openvpn] refactor import of ovpn files [th/ovpn-import-bgo761285]
[review, nm-openvpn] refactor import of ovpn files [th/ovpn-import-bgo761285]
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: VPN: openvpn
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-01-29 12:15 UTC by Thomas Haller
Modified: 2016-02-09 23:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2016-01-29 12:15:02 UTC 
Major refactoring. Please review.
Comment 1 Thomas Haller 2016-02-03 14:32:24 UTC 
refactored tests now too to use g_test_run() and nm-test-utils.h
Comment 2 Dan Williams 2016-02-05 21:26:52 UTC 
> build: add --with-more-asserts configure option for nm_assert() macro

If you don't set --with-more-asserts you end up with:

/* Define if more asserts are enabled */
#define NM_MORE_ASSERTS 

...

#if NM_MORE_ASSERTS
#define nm_assert(cond) G_STMT_START { g_assert (cond); } G_STMT_END

which isn't going to work; need to specify a default value of "no" in configure.ac.  Plus, nm-macros-internal.h should #include config.h because it uses something from it.


-------

I pushed some additional cleanups to switch everything over to g_assert() and remove the now-unused 'detail' stuff.

LGTM.