After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760945 - st-widget: Avoid passing NULL to atk_object_get_role()
st-widget: Avoid passing NULL to atk_object_get_role()
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: st
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2016-01-21 15:50 UTC by Rui Matos
Modified: 2016-01-21 17:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
st-widget: Fix a potentially infinite recursion (1.47 KB, patch)
2016-01-21 15:50 UTC, Rui Matos 		committed Details | Review
st-widget: Avoid passing NULL to atk_object_get_role() (1.22 KB, patch)
2016-01-21 15:50 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2016-01-21 15:50:16 UTC 
I was getting my logs filled with critical warnings...
Comment 1 Rui Matos 2016-01-21 15:50:20 UTC 
Created attachment 319508 [details] [review]
st-widget: Fix a potentially infinite recursion

Commit ffe4eaf00d8780bdc6fb3d7aca3eda847e887007 changed this code to
call st_widget_get_accessible_role() instead of using the value
directly which would be an infinite recursion if that function didn't
have a bug. As it is, this just resulted in

CRITICAL **: atk_object_get_role: assertion 'ATK_IS_OBJECT
(accessible)' failed
Comment 2 Rui Matos 2016-01-21 15:50:29 UTC 
Created attachment 319509 [details] [review]
st-widget: Avoid passing NULL to atk_object_get_role()

This never worked since the code landed but apparently no-one noticed
until now.

The intent here is to return the accessible's default role if none has
been explicitly set on the StWidget instance.
Comment 3 Jasper St. Pierre (not reading bugmail) 2016-01-21 15:54:12 UTC 
Review of attachment 319509 [details] [review]:

Jeez. Pretty obviously correct.
Comment 4 Jasper St. Pierre (not reading bugmail) 2016-01-21 15:54:28 UTC 
Review of attachment 319508 [details] [review]:

Yep.
Comment 5 Rui Matos 2016-01-21 17:20:55 UTC 
Attachment 319508 [details] pushed as b87da87 - st-widget: Fix a potentially infinite recursion
Attachment 319509 [details] pushed as c25c143 - st-widget: Avoid passing NULL to atk_object_get_role()