After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760679 - Build failure in Continuous
Build failure in Continuous
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-15 15:03 UTC by Emmanuele Bassi (:ebassi)
Modified: 2016-01-15 19:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix srcdir != builddir (860 bytes, patch)
2016-01-15 16:05 UTC, Michael Catanzaro
committed Details | Review

Description Emmanuele Bassi (:ebassi) 2016-01-15 15:03:29 UTC
error: GResources file `../../data/gnome-calculator.gresource.xml' does not exist
math-converter.vala:12.1-12.37: error: UI resource not found: `/org/gnome/calculator/math-converter.ui'. Please make sure to specify the proper GResources xml files with --gresources.
public class MathConverter : Gtk.Grid
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
mv -f .deps/gnome_calculator-resources.Tpo .deps/gnome_calculator-resources.Po
math-window.vala:13.1-13.47: error: UI resource not found: `/org/gnome/calculator/math-window.ui'. Please make sure to specify the proper GResources xml files with --gresources.
public class MathWindow : Gtk.ApplicationWindow
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Compilation failed: 3 error(s), 1 warning(s)
Makefile:755: recipe for target '../../src/gnome_calculator_vala.stamp' failed
make[2]: *** [../../src/gnome_calculator_vala.stamp] Error 1

This is likely caused by the autotools support for Vala messing the srcdir/builddir paths.

Simple steps to reproduce:

  $ cd gnome-calculator
  $ NOCONFIGURE=1 ./autogen.sh
  $ mkdir _build && cd _build
  $ ../configure --prefix /opt/gnome/install
  $ make

The build has been tagged in Continuous.
Comment 1 Michael Catanzaro 2016-01-15 16:05:23 UTC
The following fix has been pushed:
9831e02 Fix srcdir != builddir
Comment 2 Michael Catanzaro 2016-01-15 16:05:27 UTC
Created attachment 319116 [details] [review]
Fix srcdir != builddir
Comment 3 Michael Catanzaro 2016-01-15 19:18:48 UTC
Emmanuele noticed that my commit doesn't make any sense at all, since the gresource.xml file really does exist in srcdir and not in builddir. Something is very wrong here. I'm inclined to agree with Emmanuele, fixing this probably requires a deep dive into Automake's Vala support....

Whatever. My commit makes it work, and distcheck passes, even if it doesn't make sense.