After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760668 - box gadget: Implement cross-axis alignment
box gadget: Implement cross-axis alignment
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GtkStyleContext
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-01-15 11:59 UTC by Matthias Clasen
Modified: 2016-01-15 14:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
box gadget: Implement cross-axis alignment (10.81 KB, patch)
2016-01-15 12:00 UTC, Matthias Clasen 		none Details | Review
Update callers to box gadget api change (4.39 KB, patch)
2016-01-15 12:00 UTC, Matthias Clasen 		none Details | Review
demo (11.35 KB, image/png)
2016-01-15 12:04 UTC, Matthias Clasen 		  Details
the patch that was used for the screenshot (29.43 KB, patch)
2016-01-15 12:16 UTC, Matthias Clasen 		none Details | Review

Description Matthias Clasen 2016-01-15 11:59:59 UTC 
So far, the box gadget is always allocating all children the
full size in the cross axis. This behavior corresponds to the
align-items: stretch behavior in
https://www.w3.org/TR/css-flexbox-1/#align-items-property
This commit implements the other modes described there.

While widgets have halign/valign properties that we can use for
this, the API for inserting gadgets has to change to take an
extra align parameter.
Comment 1 Matthias Clasen 2016-01-15 12:00:03 UTC 
Created attachment 319093 [details] [review]
box gadget: Implement cross-axis alignment
Comment 2 Matthias Clasen 2016-01-15 12:00:36 UTC 
Created attachment 319094 [details] [review]
Update callers to box gadget api change

Add a GTK_ALIGN_FILL argument in all the places where
gadgets are added to a box gadget, since that corresponds
to the previous behavior.
Comment 3 Matthias Clasen 2016-01-15 12:04:33 UTC 
Created attachment 319096 [details]
demo
Comment 4 Matthias Clasen 2016-01-15 12:16:18 UTC 
Created attachment 319098 [details] [review]
the patch that was used for the screenshot