After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760637 - Handle wl_pointer v5 events (frame, axis_source, axis_discrete, axis_stop)
Handle wl_pointer v5 events (frame, axis_source, axis_discrete, axis_stop)
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
git master
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2016-01-14 18:23 UTC by Carlos Garnacho
Modified: 2016-01-19 10:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wayland: Implement wl_pointer.axis_source/axis_stop/axis_frame emission (6.95 KB, patch)
2016-01-14 18:29 UTC, Carlos Garnacho 		committed Details | Review

Description Carlos Garnacho 2016-01-14 18:23:41 UTC 
wl_pointer v5 (hot in master) provides a few extra events:

- wl_pointer.frame: Meant to coalesce wayland events that logically belong together, the most immediate case being the various wl_pointer.axis* events.

- wl_pointer.axis_source/discrete/stop: Are meant to provide further information than we get through wl_pointer.axis.

Attaching here the patch to add support in mutter.
Comment 1 Carlos Garnacho 2016-01-14 18:29:01 UTC 
Created attachment 319036 [details] [review]
wayland: Implement wl_pointer.axis_source/axis_stop/axis_frame emission

As per the spec:
- wl_pointer.axis_source determines the current source of
  scroll events.
- wl_pointer.axis_stop determines when there's no further
  scroll events on the given axis.
- wl_pointer.axis_discrete is emitted on "wheel"
  scroll sources, measured in ticks.
- wl_pointer.frame is meant to coalesce events that logically belong
  together, e.g. axis events in this case.

Co-Authored-By: Peter Hutterer <peter.hutterer@who-t.net>
Comment 2 Carlos Garnacho 2016-01-18 20:50:12 UTC 
Bug 760637 - Handle wl_pointer v5 events (frame, axis_source, axis_discrete, axis_stop) - NEW
Pushed after corroborating with the weston patches.

Attachment 319036 [details] pushed as 935d76b - wayland: Implement wl_pointer.axis_source/axis_stop/axis_frame emission
Comment 3 Jonas Ådahl 2016-01-19 09:45:25 UTC 
Review of attachment 319036 [details] [review]:

Isn't this missing the wl_pointer_send_frame() that should come together with the wl_pointer_send_enter() in meta_wayland_pointer_create_new_resource()?