After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760600 - tests: memory leak in test HTTP source
tests: memory leak in test HTTP source
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.7.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-13 22:02 UTC by Florin Apostol
Modified: 2016-01-18 13:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.08 KB, patch)
2016-01-13 22:06 UTC, Florin Apostol 		none Details | Review
proposed patch (924 bytes, patch)
2016-01-13 22:06 UTC, Florin Apostol 		none Details | Review
proposed patch (886 bytes, patch)
2016-01-14 12:17 UTC, Florin Apostol 		none Details | Review
proposed patch (939 bytes, patch)
2016-01-14 18:31 UTC, Florin Apostol 		committed Details | Review

Description Florin Apostol 2016-01-13 22:02:16 UTC 
user_agent and http_method_name properties are not released during httpsrc finalize.
Comment 1 Florin Apostol 2016-01-13 22:06:07 UTC 
Created attachment 318991 [details] [review]
proposed patch
Comment 2 Florin Apostol 2016-01-13 22:06:51 UTC 
Created attachment 318992 [details] [review]
proposed patch

uploaded correct patch
Comment 3 Florin Apostol 2016-01-14 12:17:31 UTC 
Created attachment 319007 [details] [review]
proposed patch
Comment 4 Reynaldo H. Verdejo Pinochet 2016-01-14 18:26:39 UTC 
Review of attachment 319007 [details] [review]:

Patch looks OK. Can you add the bug URL in the commit message
though? Thank you!
Comment 5 Florin Apostol 2016-01-14 18:31:11 UTC 
Created attachment 319037 [details] [review]
proposed patch

updated commit message with bug number
Comment 6 Tim-Philipp Müller 2016-01-18 13:12:01 UTC 
Pushed, thanks!

commit 38d7434bab8405d958a9a511bbbad578f0ffd62b
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Thu Jan 14 18:27:50 2016 +0000

    tests: adaptive-stremaing: fix memory leak in test_http_src
    
    https://bugzilla.gnome.org/show_bug.cgi?id=760600

(Sorry for typo, noticed too late)