After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760476 - idle-monitor-native: Don't leak user active watches
idle-monitor-native: Don't leak user active watches
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
: 756261 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-01-11 16:15 UTC by Rui Matos
Modified: 2016-05-11 13:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
idle-monitor-native: Don't leak user active watches (3.37 KB, patch)
2016-01-11 16:15 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2016-01-11 16:15:32 UTC 
This fixes an issue analogous to bug 760330 for the X11 backend,
except on this backend we wouldn't crash accessing free'd memory.

Instead we're leaking watches since we steal them from the hash table
which means that when they're removed in
_meta_idle_monitor_watch_fire() they're no longer there and thus
they're never free'd.
Comment 1 Rui Matos 2016-01-11 16:15:36 UTC 
Created attachment 318760 [details] [review]
idle-monitor-native: Don't leak user active watches
Comment 2 Jasper St. Pierre (not reading bugmail) 2016-01-11 16:21:13 UTC 
Review of attachment 318760 [details] [review]:

Code's much better.
Comment 3 Ray Strode [halfline] 2016-01-11 16:25:26 UTC 
Attachment 318760 [details] pushed as 5e57af6 - idle-monitor-native: Don't leak user active watches
Comment 4 Rui Matos 2016-05-11 13:32:43 UTC 
*** Bug 756261 has been marked as a duplicate of this bug. ***