Bug 760422 – [PATCH] gegl-tester --help shows translated characters as question marks on some locales

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 760422 - [PATCH] gegl-tester --help shows translated characters as question marks on some locales


Summary:	[PATCH] gegl-tester --help shows translated characters as question marks on s...


Status:	RESOLVED FIXED

Product:	GEGL
Classification:	Other
Component:	general
Version:	git master
Hardware:	Other All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Default Gegl Component Owner
QA Contact:	Default Gegl Component Owner

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2016-01-11 05:48 UTC by Ting-Wei Lan
Modified:	2016-02-12 09:58 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
gegl-tester: Call setlocale in main function (994 bytes, patch) 2016-01-11 05:49 UTC, Ting-Wei Lan	none	Details \| Review

Description Ting-Wei Lan 2016-01-11 05:48:13 UTC

Please see the attached patch. gegl-tester should call setlocale in main function in order to correctly show translated messages.

Running 'gegl-tester --help' with zh_TW.UTF-8 locale shows:
???
  gegl-tester [???]

?????
  -h, --help                          ???????
  --help-all                          ?????????
  --help-gegl                         Show GEGL Options

???????
  -d, --data-directory                Root directory of files used in the composition
  -r, --reference-directory           Directory where reference images are located
  -o, --output-directory              Directory where composition output and diff files are saved
  -p, --pattern                       Regular expression used to match names of operations to be tested
  -e, --exclusion-pattern             Regular expression used to match names of operations not to be tested
  -a, --all                           Create output for all operations using a standard composition if no composition is specified

Comment 1 Ting-Wei Lan 2016-01-11 05:49:00 UTC

Created attachment 318690 [details] [review]
gegl-tester: Call setlocale in main function

It is required to correctly show translated messages on some locales.

Comment 2 Michael Natterer 2016-01-11 19:43:41 UTC

This patch looks correct, and is absolutely required.

Comment 3 Øyvind Kolås (pippin) 2016-02-12 09:58:59 UTC

commit e597a3e66903e4eaa2fe4ae6657dedd6387dcef2
Author: Ting-Wei Lan <lantw@src.gnome.org>
Date:   Mon Jan 11 13:46:42 2016 +0800

    gegl-tester: Call setlocale in main function
    
    It is required to correctly show translated messages on some locales.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=760422