GNOME Bugzilla – Bug 760387
Update SourceOutput volume and mute status
Last modified: 2016-01-12 01:07:58 UTC
Created attachment 318629 [details] [review] source-sink-volume-mute-fix.patch Working with GVC to the Budgie Desktop project from Solus I noticed that the SourceOutput class wasn't implementing the change_is_muted and the change_push_volume functions as well as not getting notifications as to when this two values were updated. This patch fix both problems.
Created attachment 318630 [details] [review] Update-volume-and-mute-status.patch
Created attachment 318631 [details] [review] 0001-Update-volume-and-mute-status.patch
Created attachment 318632 [details] [review] 0002-Update-PA-about-volume-and-mute-status-changes.patch
(In reply to Carlos Silva from comment #0) <snip> > This patch fix both problems. What does this actually fix?
(In reply to Bastien Nocera from comment #4) > > What does this actually fix? Not being able to update the volume and mute status from SourceOutput streams as well as not being notified about those changes from and outside aplication
Created attachment 318832 [details] [review] gvc-mixer-source-output: Update volume and mute status This commit implements notifying about volume and mute status changes for source outputs (applications that monitor the microphone, in short).
I've updated the patch to match what I would expect it to look like, but I still don't understand why you'd want to change the volume, or monitor the volume of sources monitoring the microphone. Or do you have another use for this feature? In which case, I'd like to hear it, and that's also what I was asking in comment 4.
Oh! So you want a big patch with all the changes in it? I can do that too (I just used git format-patch) The use case is a system volume manager where you can control all the volumes of all the streams (same as pavucontrol does). Since we'll be showing the "input" streams too, it just seems natural that you could control those volumes too (since you actually can, not just with something based on gvc). [offtopic] I actually have a few more patches coming in (not related to this), but wanted to discuss them with you. Do you hand around IRC or something?
(In reply to Carlos Silva from comment #8) > Oh! So you want a big patch with all the changes in it? I can do that too (I > just used git format-patch) > > > The use case is a system volume manager where you can control all the > volumes of all the streams (same as pavucontrol does). Since we'll be > showing the "input" streams too, it just seems natural that you could > control those volumes too (since you actually can, not just with something > based on gvc). I really don't see that as useful, but seeing as that backend code is getting reused. > [offtopic] > I actually have a few more patches coming in (not related to this), but > wanted to discuss them with you. Do you hand around IRC or something? Filing bugs is probably a better way to discuss patches that exist. #control-center on GNOME IRC otherwise.
Attachment 318832 [details] pushed as d4eda71 - gvc-mixer-source-output: Update volume and mute status