After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760328 - adaptivedemux: tests: clean tests
adaptivedemux: tests: clean tests
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.7.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-08 16:57 UTC by Florin Apostol
Modified: 2016-02-09 13:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch 1/4 (1.42 KB, patch)
2016-01-08 16:58 UTC, Florin Apostol 		none Details | Review
patch 2/4 (2.30 KB, patch)
2016-01-08 16:59 UTC, Florin Apostol 		committed Details | Review
patch 3/4 (1.82 KB, patch)
2016-01-08 16:59 UTC, Florin Apostol 		committed Details | Review
patch 4/4 (2.74 KB, patch)
2016-01-08 17:00 UTC, Florin Apostol 		committed Details | Review
patch 1/4 (4.14 KB, patch)
2016-01-08 18:24 UTC, Florin Apostol 		committed Details | Review

Description Florin Apostol 2016-01-08 16:57:45 UTC 
There are a few small loose ends in test. Here's a collection of patches to clean them.
Comment 1 Florin Apostol 2016-01-08 16:58:18 UTC 
Created attachment 318517 [details] [review]
patch 1/4

remove unneeded youtube xmlns from manifests
Comment 2 Florin Apostol 2016-01-08 16:59:10 UTC 
Created attachment 318518 [details] [review]
patch 2/4

remove unused demux_sent_eos callback
Comment 3 Florin Apostol 2016-01-08 16:59:43 UTC 
Created attachment 318519 [details] [review]
patch 3/4

fix pad used for AppSink event
Comment 4 Florin Apostol 2016-01-08 17:00:21 UTC 
Created attachment 318520 [details] [review]
patch 4/4

improved validation of pads
Comment 5 Florin Apostol 2016-01-08 18:24:52 UTC 
Created attachment 318535 [details] [review]
patch 1/4

remove unneeded youtube xmlns from manifests (for all tests)
Comment 6 Thiago Sousa Santos 2016-02-09 13:57:09 UTC 
commit 13f66a68edfc54f51c7743ac671d1a3eea164d38
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Thu Jan 7 12:50:06 2016 +0000

    adaptive_demux: tests: improved validation of pads
    
    When removing a pad, the on_demuxPadRemoved function must find a stream
    for that pad.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=760328

commit 7ed4f6f03fb374828dad06810c01341537cf4f92
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Thu Jan 7 12:48:12 2016 +0000

    adaptive_demux: tests: fix pad used for AppSink event
    
    on_demuxNewPad registered the on_appsink_event callback on a wrong pad.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=760328

commit 97c562ecbf2120bcdc99761f29026f5e64c3c992
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Fri Jan 8 16:25:12 2016 +0000

    adaptivedemux: tests: remove unused demux_sent_eos callback
    
    The demux_sent_eos callback is unused in tests. It was also registered on
    a wrong pad, so it actually triggered when demux received eos from a
    fragment download.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=760328

commit d07484c8379629ff281760169670651556c1472b
Author: Florin Apostol <florin.apostol@oregan.net>
Date:   Fri Jan 8 18:17:21 2016 +0000

    adaptivedemux: tests: remove unneeded youtube xmlns from manifests
    
    https://bugzilla.gnome.org/show_bug.cgi?id=760328