After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760239 - matroskademux : capture tag from sink event and merge it to global tags
matroskademux : capture tag from sink event and merge it to global tags
Status: RESOLVED INCOMPLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-01-06 21:10 UTC by Yannick Inizan
Modified: 2018-05-06 12:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] matroska demux : capture tag from sink event and merge it to global tags (1.23 KB, patch)
2016-01-06 21:10 UTC, Yannick Inizan
none Details | Review
[PATCH] Allow matroska demux to propagate incoming tags from sink (1.18 KB, patch)
2016-01-06 23:56 UTC, Yannick Inizan
needs-work Details | Review

Description Yannick Inizan 2016-01-06 21:10:45 UTC
Created attachment 318384 [details] [review]
[PATCH] matroska demux : capture tag from sink event and merge it to global tags

capture tag from sink event and merge it to global tags
Comment 1 Sebastian Dröge (slomo) 2016-01-06 22:27:05 UTC
Review of attachment 318384 [details] [review]:

::: gst/matroska/matroska-demux.c
@@ +4840,3 @@
+      gst_event_parse_tag (event, &new_list);
+      gst_matroska_read_common_found_global_tag (&demux->common,
+          GST_ELEMENT_CAST (demux), new_list);

After this gst_matroska_demux_send_tags() needs to be called at some point. Maybe should be called before every gst_pad_push()?

In your case it probably works without because your tags arrive before the header of the Matroska file is parsed, and during header parsing that function is called anyway.
Comment 2 Yannick Inizan 2016-01-06 23:56:27 UTC
Created attachment 318391 [details] [review]
[PATCH] Allow matroska demux to propagate incoming tags from sink
Comment 3 Yannick Inizan 2016-01-06 23:56:43 UTC
missing line added
Comment 4 Sebastian Dröge (slomo) 2016-01-07 12:34:49 UTC
Review of attachment 318391 [details] [review]:

::: gst/matroska/matroska-demux.c
@@ +4841,3 @@
+      gst_matroska_read_common_found_global_tag (&demux->common,
+          GST_ELEMENT_CAST (demux), new_list);
+      gst_matroska_demux_send_tags (demux);

I don't think that works as is... you don't necessarily have any source pads at this point. That's why I said it should probably happen before pushing buffers... but maybe *also* before pushing buffers and having it here.
Comment 5 Yannick Inizan 2016-01-07 14:51:04 UTC
register tags in sink function and send tags in chain function ?
Comment 6 Sebastian Dröge (slomo) 2016-02-16 11:34:03 UTC
Yes, any progress here?
Comment 7 Vivia Nikolaidou 2018-05-06 12:19:41 UTC
Closing this bug report as no further information has been provided. Please feel free to reopen this bug report if you can provide the information that was asked for in a previous comment.
Thanks!