GNOME Bugzilla – Bug 760066
Add keyboard shortcut to go to user's location
Last modified: 2016-01-05 18:43:59 UTC
This bug was opened as there is no shortcut currently for going to the user's current location . The accel could be Primary + L or something along those lines
Created attachment 318153 [details] [review] Adds shortcut for user's current location
Created attachment 318154 [details] Screenshot of above patch
Review of attachment 318153 [details] [review]: Thanks Karanbir! Please mind the length of the commit body! Follow this guide: https://wiki.gnome.org/Git/CommitMessages ::: data/ui/help-overlay.ui @@ +34,3 @@ <object class="GtkShortcutsShortcut"> <property name="visible">1</property> + <property name="title" translatable="yes">Go to user's current location</property> So two things! 1) It will be "the user" that is reading this, right? So just "Go to current location" makes more sense. 2) I think this belong under the Map View category, since it is an action that affects the map view.
Created attachment 318159 [details] [review] Revised Patch
Review of attachment 318159 [details] [review]: Thanks! Please no '&' in the commit message. You can split the body to two sentences and two lines. ::: data/ui/help-overlay.ui @@ +40,3 @@ + <child> + <object class="GtkShortcutsShortcut"> + <property name="visible">1</property> This is still under the general bindings, right? I think this should be under Map View, do you not agree?
Also a guide to work with bugzilla and git easier: https://wiki.gnome.org/Projects/GnomeShell/Development/WorkingWithPatches
Created attachment 318233 [details] [review] corrections made
Created attachment 318234 [details] Screenshot
Review of attachment 318233 [details] [review]: The commit message is mentioning the wrong Bugzilla ticket. Also, as a sidenote, just some thoughts about the proper shortcut. <Primary>L is usually a shortcut to focus the location bar in Files and URL bar in Web, so maybe <Primary>L should behave the same as <Primary>F. But then I see Apple Maps using <Primary>L to go to current location and Safari also uses <Primary>L to focus the location bar. Personally, I'd like a different shortcut (Ctrl + U or Alt + L). How valid is my opinion or how important is to think too much about this, I don't know :D
Created attachment 318261 [details] [review] Patch
I changed the bugzilla link.Should I change the accel too?
(In reply to Karanbir Chahal from comment #11) > I changed the bugzilla link.Should I change the accel too? Thanks. No, I think we are fine, that was just a personal opinion. Unless anybody else has anything to say about this, the patch looks good to me. (Remember to take a look to the links provided by Jonas, mainly for start using git-bz, that's going to save you lot of time.)
ALright.I'm sorry for all the mess.
(In reply to Karanbir Chahal from comment #13) > ALright.I'm sorry for all the mess. No need! Thank you for working on this. I think <Primary>L is fine, since Apple Maps seem to use the same.
Pushed as: https://git.gnome.org/browse/gnome-maps/commit/?id=432a5af20589d232a8c278d55e721f646a603c53
If you want to keep improving keyboard shortcuts, maybe this can be next: https://bugzilla.gnome.org/show_bug.cgi?id=759574