After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759948 - caps: add 'transfer full' annotation to caps returned by intersection functions
caps: add 'transfer full' annotation to caps returned by intersection functions
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: 1.6.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-12-29 10:18 UTC by Aurélien Zanelli
Modified: 2016-01-03 08:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
caps: add 'transfer full' annotation to caps returned by interserction functions (1.60 KB, patch)
2015-12-29 10:19 UTC, Aurélien Zanelli 		committed Details | Review

Description Aurélien Zanelli 2015-12-29 10:18:51 UTC 
Return value (GstCaps) of gst_caps_intersect () and gst_caps_intersect_full () functions are new GstCaps which should be unref by caller but there are not annotated as 'transfer full'.
Comment 1 Aurélien Zanelli 2015-12-29 10:19:47 UTC 
Created attachment 318000 [details] [review]
caps: add 'transfer full' annotation to caps returned by interserction functions
Comment 2 Sebastian Dröge (slomo) 2015-12-29 12:34:36 UTC 
commit 2c272d74fd173148ce6c4137a454bc70cf71a911
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Tue Dec 29 14:32:47 2015 +0200

    caps: Add (transfer full) annotation to simplify() and subtract() return value
    
    https://bugzilla.gnome.org/show_bug.cgi?id=759948

commit 2ee33237c8530a89820971bff5ff0b6aec3b46aa
Author: Aurélien Zanelli <aurelien.zanelli@parrot.com>
Date:   Tue Dec 29 11:06:39 2015 +0100

    caps: add 'transfer full' annotation to caps returned by interserction functions
    
    To make clear caller is responsible to unref them.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=759948