After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759619 - processor: Handle non-meta-op sub-graphs transparently
processor: Handle non-meta-op sub-graphs transparently
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: general
git master
Other All
: Normal enhancement
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2015-12-18 09:13 UTC by Debarshi Ray
Modified: 2016-02-13 14:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
processor: Rename an internal class variable (6.91 KB, patch)
2015-12-18 09:18 UTC, Debarshi Ray
none Details | Review
processor: Handle non-meta-op sub-graphs transparently (3.19 KB, patch)
2015-12-18 09:19 UTC, Debarshi Ray
none Details | Review
processor: Rename an internal class variable (6.90 KB, patch)
2016-02-12 23:01 UTC, Debarshi Ray
none Details | Review
processor: Handle non-meta-op sub-graphs transparently (3.18 KB, patch)
2016-02-12 23:02 UTC, Debarshi Ray
none Details | Review

Description Debarshi Ray 2015-12-18 09:13:59 UTC
Currently, if you want to process a GeglNode that is a sub-graph, but not one with a meta operation, then you can't just process it directly. You have to get the output proxy and process it. My use-case is a sub-graph that contains all the operations that are applied on a GeglBuffer source.

It would be nice to handle this transparently, just like other parts of the API do.
Comment 1 Debarshi Ray 2015-12-18 09:18:37 UTC
Created attachment 317612 [details] [review]
processor: Rename an internal class variable
Comment 2 Debarshi Ray 2015-12-18 09:19:09 UTC
Created attachment 317613 [details] [review]
processor: Handle non-meta-op sub-graphs transparently
Comment 3 Debarshi Ray 2016-02-12 23:01:55 UTC
Created attachment 321049 [details] [review]
processor: Rename an internal class variable

Rebased on top of master.
Comment 4 Debarshi Ray 2016-02-12 23:02:32 UTC
Created attachment 321050 [details] [review]
processor: Handle non-meta-op sub-graphs transparently
Comment 5 Øyvind Kolås (pippin) 2016-02-13 14:19:06 UTC
These changes do not seem to change the behavior of GIMP nor the GEGL ui - pushing to master to get more throughout testing.

commit 5a7ccff73bdabe13ffdad188e3fb3f6589a00a2f
Author: Debarshi Ray <debarshir@gnome.org>
Date:   Fri Dec 18 10:14:17 2015 +0100

    processor: Handle non-meta-op sub-graphs transparently
    
    https://bugzilla.gnome.org/show_bug.cgi?id=759619

commit 2719d36def5baa9585937c77f4e0f19c93689ae1
Author: Debarshi Ray <debarshir@gnome.org>
Date:   Fri Dec 18 08:53:48 2015 +0100

    processor: Rename an internal class variable
    
    This will be useful in adding support for transparent handling of
    non-meta-op sub-graphs.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=759619