GNOME Bugzilla – Bug 759488
Pending create partitions are all getting named "unallocated"
Last modified: 2016-01-18 17:42:18 UTC
Compose creation of 2 or more primary or logical partition on MSDOS or GPT and even across multiple disk devices. Delete any of them. All are removed from the pending list of operations. Occurs with current GParted GIT head 0.24.0-master-18-g5b0465e. Not in GParted 0.24.0. Bisected to this commit: Return class member from Dialog_Partition_New::Get_New_Partition() (#757671) https://git.gnome.org/browse/gparted/commit/?id=762cd1094aece03986226a39d1f6b4fecfd73ee9 At the moment this makes no sense.
The difference is that the above mentioned commit wrongly causes newly created partitions to get path names of "unallocated" instead of "New Partition #1", etc. Then in Win_GParted::activate_delete() when it is looking for pending create operations to delete it matches on the path names so all pending creates match and get removed, rather than just the single desired partition. Will fix this, Mike
Update description from: Deleting one pending create partition, removes all pending creates to: Pending create partitions are all getting named "unallocated"
Created attachment 317576 [details] [review] Fix temporary path name of new partitions (v1) Hi Curtis, Here is the patch for this. Thanks, Mike
Hi Mike, Thanks for discovering this problem and providing a patch. I tested 0.24.0 to confirm the problem did not exist. Next I tested the git head and confirmed that the problem existed in the latest git master. Then I tested with your patch v1 in comment #3 and confirmed that the patch fixes the problem. I plan to commit this patch tomorrow along with another we recently worked on. Curtis
Patch v1 from comment #3 has been committed to the git repository for inclusion in the next release of GParted. The relevant git commit can be viewed at the following link: Fix temporary path name of new partitions (#759488) https://git.gnome.org/browse/gparted/commit/?id=c249b7286d552cffcfc661831715260e3196a354
This enhancement was included in the GParted 0.25.0 release on January 18, 2016.