After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759384 - Generate the symbolic icon set for dark themes
Generate the symbolic icon set for dark themes
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
git master
Other All
: Normal normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2015-12-12 12:37 UTC by Jehan
Modified: 2015-12-20 17:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Icon set generation for dark themes. (56.94 KB, patch)
2015-12-12 12:37 UTC, Jehan
none Details | Review

Description Jehan 2015-12-12 12:37:54 UTC
Created attachment 317246 [details] [review]
Icon set generation for dark themes.

So if I gathered well, GTK+3 will be able to invert monochrome icons directly for dark themes, but there is no way to do this automatically in GTK+2 (Bug 759105, comment 68).

So for 2.10, let's just generate the icon set usable for dark themes from the committed icon set for light theme.

The attached patch does this. It uses gegl from command line with "gegl:invert-linear" operation to invert the colors and create another set of icons at build time, making sure the dark theme will be the complete equivalent of the light theme.

I called the generated icon set "Symbolic-dark" because it is made to work over dark themes, but since the icons are actually "whiter" than the Symbolic one, I find it confusing. Somehow it should be called "Symbolic-light", but the Symbolic-light *icon set* would go with the Symbolic-dark *theme* (and vice-versa), which is also confusing.

Any better idea how to call the light icon set made to work with dark themes?
Comment 1 Jehan 2015-12-20 16:46:20 UTC
commit 94aec7cb6c91165c29eeb72b48b3e1b885b0407b
Author: Jehan <jehan@girinstud.io>
Date:   Sat Dec 12 13:25:21 2015 +0100

    icons: generate "negative" color symbolic icons.
    
    The negative icons are generated from the Symbolic icon theme with
    the GEGL operation 'gegl:invert-linear'.