GNOME Bugzilla – Bug 759345
Fix for prefs dialog to add icon theme support
Last modified: 2015-12-12 11:44:31 UTC
Created attachment 317202 [details] [review] patch that adds icon theme support to prefs dialog This patch fixes the preferences dialog to add icon theme support.
Thanks a lot, but, um, GtkCellrendererPixbuf does that job just fine...
It didn't work here (and yes i had new .config folder here) now when i swap the icon theme the prefs dialog changes with this patch. where it didn't before.
To clarify the original way worked when the app loaded but when swapping the icon theme i still had the original in prefs even though it changed every where else, now with this patch it also swaps to the new one.
refer to my comments on this from the original bug report for icon theme i have screenshots there of the issue. (759105)
Applying and trying as we speak...
Nice patch, but please don't mix code and declarations, all variables must be declared at the beginning of the block. I'm fixing this locally...
Thanks, will remember that in the future, sorry.
No problem, each code base has different rules :) Anyway, I'm sorry that you went through the effort of making that cell renderer, because it works absolutely fine with the default GTK+ renderer. Also, can you please fix your git config to have your name in it? Because that's also how you will be credited in AUTHORS. commit 55270366d7734953a2d6f1c4420f7f5bada10031 Author: Benoit Touchette <draekko.sofware@gmail.com> Date: Fri Dec 11 06:29:50 2015 -0500 Bug 759345 - Fix for prefs dialog to add icon theme support Change GimpPrefsBox to use icon names instead of pixbufs, and change preferences-dialog.c accordingly. app/dialogs/preferences-dialog.c | 210 ++++++++++++++++++++++++-------------------------- app/widgets/gimpprefsbox.c | 92 +++++++++++----------- app/widgets/gimpprefsbox.h | 24 +++--- 3 files changed, 163 insertions(+), 163 deletions(-)
Ok will check to fix that.