After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 759310 - Metacity Icon For .desktop File
Metacity Icon For .desktop File
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
trunk
Other Linux
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2015-12-10 16:16 UTC by Subin Siby
Modified: 2016-02-22 13:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Ignore this. Wrong attachment (16.76 KB, patch)
2015-12-10 16:16 UTC, Subin Siby
none Details | Review
Patch adding the SVG icon (16.02 KB, patch)
2015-12-10 16:26 UTC, Subin Siby
none Details | Review
Patch updating the .desktop file (1.06 KB, patch)
2015-12-10 16:27 UTC, Subin Siby
none Details | Review
Patch for adding rules in Makefile for adding icon (613 bytes, patch)
2015-12-10 16:33 UTC, Subin Siby
none Details | Review
Patch updating the .desktop file (1.03 KB, patch)
2015-12-10 17:33 UTC, Subin Siby
none Details | Review

Description Subin Siby 2015-12-10 16:16:37 UTC
Created attachment 317154 [details] [review]
Ignore this. Wrong attachment

As per Metadata processing hints (http://162.213.34.169/html/xenial/main/issues/index.html), metacity's .desktop file lacked an icon.
I'm attaching a patch that contains the icon file (SVG) and the updated .desktop file.
Comment 1 Subin Siby 2015-12-10 16:26:44 UTC
Created attachment 317156 [details] [review]
Patch adding the SVG icon
Comment 2 Subin Siby 2015-12-10 16:27:07 UTC
Created attachment 317157 [details] [review]
Patch updating the .desktop file
Comment 3 Subin Siby 2015-12-10 16:33:03 UTC
Created attachment 317158 [details] [review]
Patch for adding rules in Makefile for adding icon
Comment 4 Alberts Muktupāvels 2015-12-10 17:01:32 UTC
Your patch changes 'Icon=metacity-icon' to 'Icon=metacity', but upstream .desktop files does not have Icon= line...
Comment 5 Subin Siby 2015-12-10 17:32:30 UTC
Comment on attachment 317157 [details] [review]
Patch updating the .desktop file

From 4fbdc6b111e6bdc0de71f8481c75139d3d281899 Mon Sep 17 00:00:00 2001
From: subins2000 <subins2000@gmail.com>
Date: Thu, 10 Dec 2015 21:51:57 +0530
Subject: [PATCH 2/3] Added Icon= param in desktop files

---
 src/metacity-wm.desktop.in | 2 +-
 src/metacity.desktop.in    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/metacity-wm.desktop.in b/src/metacity-wm.desktop.in
index d2504af..083bd5e 100644
--- a/src/metacity-wm.desktop.in
+++ b/src/metacity-wm.desktop.in
@@ -2,7 +2,7 @@
 Type=Application
 _Name=Metacity
 Exec=metacity
+Icon=metacity
 # name of loadable control center module
 X-GNOME-WMSettingsModule=metacity
 # name we put on the WM spec check window
diff --git a/src/metacity.desktop.in b/src/metacity.desktop.in
index 19e4544..274c981 100644
--- a/src/metacity.desktop.in
+++ b/src/metacity.desktop.in
@@ -1,8 +1,8 @@
 [Desktop Entry]
 Type=Application
 _Name=Metacity
 Exec=metacity
+Icon=metacity
 NoDisplay=true
 # name of loadable control center module
 X-GNOME-WMSettingsModule=metacity
-- 
2.5.0
Comment 6 Subin Siby 2015-12-10 17:33:13 UTC
Created attachment 317161 [details] [review]
Patch updating the .desktop file
Comment 7 Alberts Muktupāvels 2016-02-22 13:51:26 UTC
Thanks for patches, but icon does not look good enough for me. Probably because  of black border. For now I added preferences-system-windows as metacity icon - this is same icon that is used by gnome-system-monitor for metacity and gnome-shell.