Bug 75897 – Working with any submenu after the menu panel applet is removed results in a crash

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 75897 - Working with any submenu after the menu panel applet is removed results in a crash


Summary:	Working with any submenu after the menu panel applet is removed results in a...


Status:	RESOLVED INVALID

Product:	gnome-applets
Classification:	Other
Component:	menu applet
Version:	unspecified
Hardware:	Other Solaris

Importance:	High critical
Target Milestone:	---
Assigned To:	Chris Phelps
QA Contact:	gnome-applets Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2002-03-22 12:23 UTC by Jathish
Modified:	2006-02-13 07:28 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Removes the "Add items ..." dialog when removing applet from panel. (2.72 KB, patch) 2002-04-23 09:55 UTC, Senthilkumar Ramasamy	none	Details \| Review
Removes the "Add items .." dialog when applet is removed from panel. (3.56 KB, patch) 2002-04-25 06:22 UTC, Senthilkumar Ramasamy	none	Details \| Review

Description Jathish 2002-03-22 12:23:25 UTC

Gnome Beta 2 was built on a Solaris 9 (32 bit) sun sparc machine.
menubar applet version 0.0.1

Description: Working with any submenu after the  menu panel applet is 
removed results in a crash

Steps:
1. Open menbar applet "Add to Panel -> Utility -> Menu Bar"
2. Right click and select "add".
3. Right click on the menu applet and select "Remove from panel"
4. The submenu remains open.
5. click on "Directory item" and "Ok"
The applet crashes.

Stack trace:
Program received signal SIGSEGV, Segmentation fault.
0xfe35afe0 in g_list_last () from /opt/gnome-2.0/lib/libglib-2.0.so.0
(gdb) where

+ Trace 19630

#0 g_list_last
from /opt/gnome-2.0/lib/libglib-2.0.so.0
#1 g_list_append
from /opt/gnome-2.0/lib/libglib-2.0.so.0
#2 panel_menu_directory_new_with_dialog
#3 panel_menu_add_entry_cb
#4 g_cclosure_marshal_VOID__VOID
from /opt/gnome-2.0/lib/libgobject-2.0.so.0
#5 g_closure_invoke
from /opt/gnome-2.0/lib/libgobject-2.0.so.0
#6 signal_emit_unlocked_R
from /opt/gnome-2.0/lib/libgobject-2.0.so.0
#7 g_signal_emit_valist
from /opt/gnome-2.0/lib/libgobject-2.0.so.0
#8 gtk_signal_emit
from /opt/gnome-2.0/lib/libgtk-x11-2.0.so.0
#9 gtk_button_clicked
from /opt/gnome-2.0/lib/libgtk-x11-2.0.so.0
#10 gtk_real_button_released
from /opt/gnome-2.0/lib/libgtk-x11-2.0.so.0
#11 g_cclosure_marshal_VOID__VOID
from /opt/gnome-2.0/lib/libgobject-2.0.so.0
#12 g_type_class_meta_marshal
from /opt/gnome-2.0/lib/libgobject-2.0.so.0
#13 g_closure_invoke
#14 signal_emit_unlocked_R
from /opt/gnome-2.0/lib/libgobject-2.0.so.0
#15 g_signal_emit_valist
from /opt/gnome-2.0/lib/libgobject-2.0.so.0
#16 gtk_signal_emit
from /opt/gnome-2.0/lib/libgtk-x11-2.0.so.0
#17 gtk_button_released
from /opt/gnome-2.0/lib/libgtk-x11-2.0.so.0
#18 gtk_button_button_release
from /opt/gnome-2.0/lib/libgtk-x11-2.0.so.0
#19 _gtk_marshal_BOOLEAN__BOXED
from /opt/gnome-2.0/lib/libgtk-x11-2.0.so.0
#20 g_type_class_meta_marshal
from /opt/gnome-2.0/lib/libgobject-2.0.so.0
#21 g_closure_invoke
from /opt/gnome-2.0/lib/libgobject-2.0.so.0
#22 signal_emit_unlocked_R
from /opt/gnome-2.0/lib/libgobject-2.0.so.0
#23 g_signal_emit_valist
from /opt/gnome-2.0/lib/libgobject-2.0.so.0
#24 gtk_signal_emit
from /opt/gnome-2.0/lib/libgtk-x11-2.0.so.0
#25 gtk_widget_event_internal
from /opt/gnome-2.0/lib/libgtk-x11-2.0.so.0
#26 gtk_widget_event
from /opt/gnome-2.0/lib/libgtk-x11-2.0.so.0
#27 gtk_propagate_event
from /opt/gnome-2.0/lib/libgtk-x11-2.0.so.0
#28 gtk_main_do_event
from /opt/gnome-2.0/lib/libgtk-x11-2.0.so.0
#29 gdk_event_dispatch
from /opt/gnome-2.0/lib/libgdk-x11-2.0.so.0
#30 g_main_dispatch
from /opt/gnome-2.0/lib/libglib-
#31 g_main_context_dispatch
from /opt/gnome-2.0/lib/libglib-2.0.so.0
#32 g_main_context_iterate
from /opt/gnome-2.0/lib/libglib-2.0.so.0
#33 g_main_loop_run
from /opt/gnome-2.0/lib/libglib-
#34 bonobo_main
from /opt/gnome-2.0/lib/libbonobo-2.so.0
#35 bonobo_generic_factory_main
from /opt/gnome-2.0/lib/libbonobo-2.so.0
#36 panel_applet_factory_main_closure
from /opt/gnome-2.0/lib/libpanel-applet-2.so.0
#37 panel_applet_factory_main
from /opt/gnome-2.0/lib/libpanel-applet-2.so.0
#38 main

Comment 1 Senthilkumar Ramasamy 2002-04-23 09:55:30 UTC

Created attachment 7883 [details] [review]
Removes the "Add items ..." dialog when removing applet from panel.

Comment 2 Kevin Vandersloot 2002-04-23 17:35:01 UTC

Though the patch works, I don't think it is the right thing to do. It
would also fail if multiple instances of the applet were run (since
they share the same global data structures). I think the dialog should
be destroyed when the applet is removed automatically. This may be a
gnome-panel issue, I will try to contact Mark about it (it also only
happens for in-process applets)

Comment 3 Kevin Vandersloot 2002-04-25 03:11:32 UTC

CC'ing Mark on this one.

Mark: the problem here is that the panel-menu-applet dialog is not
destroyed when the applet is removed from the panel. This only happens
with in-proc applets. Is this the applets fault or the panels?

Comment 4 Senthilkumar Ramasamy 2002-04-25 06:20:01 UTC

Since the dialog box is created by applet, the applet should take
the responsibility of cleaning it when the applet is removed from
the panel. So i don't think its a panel issue.

Comment 5 Senthilkumar Ramasamy 2002-04-25 06:22:26 UTC

Created attachment 7943 [details] [review]
Removes the "Add items .." dialog when applet is removed from panel.

Comment 6 Senthilkumar Ramasamy 2002-04-25 06:24:30 UTC

Fix: 
i have added one more pointer to PanelMenu struct, in which i am
storing the reference to the dialog box. When applet is removed from
panel, i am using this reference to destroy the dialog box. 
This will take care of multiple instances of applet. 

I have also taken care to avoid multiple instances of dialog boxes for
the same applet.

Comment 7 Luis Villa 2002-04-25 20:06:43 UTC

Noting for the record that mark just left for two weeks so we're on
hold a bit with his responses :)

Comment 8 Luis Villa 2002-05-01 10:38:10 UTC

Oh, if this is a menu applet patch/problem, isn't this chicane's bug?

Comment 9 Kevin Vandersloot 2002-05-10 03:03:18 UTC

Hoepfully we can get this fixed

Comment 10 Kevin Vandersloot 2002-05-14 21:58:30 UTC

Post GNOME2 since we are not shipping panel-menu-applet by default

Comment 11 Kevin Vandersloot 2003-02-13 15:25:53 UTC

Menu panel will be removed from gnome-applets