After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758908 - The app chooser dialog uses a non standard icon and doesn't wrap when needed
The app chooser dialog uses a non standard icon and doesn't wrap when needed
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkAppChooser
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Cosimo Cecchi
Depends on:
Blocks:
 
 
Reported: 2015-12-01 17:01 UTC by Sebastien Bacher
Modified: 2015-12-03 11:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot showing the issue (20.08 KB, image/png)
2015-12-01 17:01 UTC, Sebastien Bacher 		  Details
wrap the label and use a standard icon (1.47 KB, patch)
2015-12-02 12:50 UTC, Sebastien Bacher 		committed Details | Review

Description Sebastien Bacher 2015-12-01 17:01:03 UTC 
Created attachment 316616 [details]
screenshot showing the issue

Using gtk 3.18.5 and nautilus 3.18.2 in a french locale
- right click on a python script in nautilus
- select "open with another software"
- look at the dialog

-> the label goes over the window, it should wrap instead, also gtkappchooserwidget.ui uses the icon "gnome-software-symbolic" which seems to be part of the gnome-software application and not from the standard themes
Comment 1 Matthias Clasen 2015-12-01 17:51:07 UTC 
I agree that the label should be wrapped. If you want to donate a patch, the file to look at is gtk/ui/gtkappchooserwidget.ui.
Comment 2 Jakub Steiner 2015-12-01 22:23:18 UTC 
I suggest using application-x-executable-symbolic for the watermark
Comment 3 Sebastien Bacher 2015-12-02 12:50:12 UTC 
Created attachment 316657 [details] [review]
wrap the label and use a standard icon
Comment 4 Matthias Clasen 2015-12-03 00:53:29 UTC 
Review of attachment 316657 [details] [review]:

Looks right, thanks
Comment 5 Sebastien Bacher 2015-12-03 11:48:27 UTC 
Review of attachment 316657 [details] [review]:

Commited as https://git.gnome.org/browse/gtk+/commit/?id=635da3490

Can I cherrypick to 3-18 as well or is the icon change considered as an UI change?