After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758790 - A few stylistic icon-browser patches
A few stylistic icon-browser patches
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-11-28 20:19 UTC by Timm Bäder
Modified: 2015-11-30 16:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
icon-browser: baseline-align the icon size labels (2.65 KB, patch)
2015-11-28 20:20 UTC, Timm Bäder 		accepted-commit_now Details | Review
icon-browser: Use proper "times" character (2.51 KB, patch)
2015-11-28 20:20 UTC, Timm Bäder 		accepted-commit_now Details | Review
icon-browser: Stop using GtkMisc properties (5.35 KB, patch)
2015-11-28 20:20 UTC, Timm Bäder 		accepted-commit_now Details | Review

Description Timm Bäder 2015-11-28 20:19:58 UTC 
A bit too much for me to just push them, but harmless.
Comment 1 Timm Bäder 2015-11-28 20:20:05 UTC 
Created attachment 316452 [details] [review]
icon-browser: baseline-align the icon size labels
Comment 2 Timm Bäder 2015-11-28 20:20:15 UTC 
Created attachment 316453 [details] [review]
icon-browser: Use proper "times" character
Comment 3 Timm Bäder 2015-11-28 20:20:23 UTC 
Created attachment 316454 [details] [review]
icon-browser: Stop using GtkMisc properties

Instead of xpad/ypad of 4 for every widget, just increase the
row-spacing and column-spacing by 8.
Comment 4 Matthias Clasen 2015-11-30 13:11:05 UTC 
Review of attachment 316452 [details] [review]:

sure
Comment 5 Matthias Clasen 2015-11-30 13:11:40 UTC 
Review of attachment 316453 [details] [review]:

of course
Comment 6 Matthias Clasen 2015-11-30 13:13:08 UTC 
Review of attachment 316454 [details] [review]:

fine with me
Comment 7 Timm Bäder 2015-11-30 16:44:01 UTC 
All pushed to master, thanks.