After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758768 - documentation - add CameraManager, Types and index; fix build warnings
documentation - add CameraManager, Types and index; fix build warnings
Status: RESOLVED FIXED
Product: clutter-gst
Classification: Other
Component: general
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: clutter-gst-maint
clutter-gst-maint
Depends on:
Blocks:
 
 
Reported: 2015-11-28 10:49 UTC by Chris Mayo
Modified: 2016-02-14 23:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix typo in video_sink_get_frame return value (1007 bytes, patch)
2015-11-28 10:51 UTC, Chris Mayo
committed Details | Review
add missing parameter description for content_new_with_sink (776 bytes, patch)
2015-11-28 10:51 UTC, Chris Mayo
committed Details | Review
don't use tmpl build step when creating documentation (906 bytes, patch)
2015-11-28 10:52 UTC, Chris Mayo
committed Details | Review
add API indices (1.98 KB, patch)
2015-11-28 10:54 UTC, Chris Mayo
committed Details | Review
add annotation glossary (919 bytes, patch)
2015-11-28 10:54 UTC, Chris Mayo
committed Details | Review
add ClutterGst types (2.55 KB, patch)
2015-11-28 10:55 UTC, Chris Mayo
committed Details | Review
add CameraManager (856 bytes, patch)
2015-11-28 10:56 UTC, Chris Mayo
committed Details | Review

Description Chris Mayo 2015-11-28 10:49:49 UTC
Some suggestions attached to improve the docs.

Fixing build warnings:
0001 fix typo in video_sink_get_frame return value 
0002 add missing parameter description for content_new_with_sink
0003 don't use tmpl build step when creating documentation

0004 add API indices

Provide targets for cross-references and replaces external links to foldoc.org:
0005 add annotation glossary (also fixes build warnings)
0006 add Clutter-Gst types

0007 add CameraManager


Some build warnings remain:

../../clutter-gst/clutter-gst-types.h:107: warning: Field description for ClutterGstVideoResolution::par_n is missing in source code comment block.
../../clutter-gst/clutter-gst-types.h:107: warning: Field description for ClutterGstVideoResolution::par_d is missing in source code comment block.
../../clutter-gst/clutter-gst-playback.h:98: warning: Field description for ClutterGstPlaybackClass::should_buffer is missing in source code comment block.
../../clutter-gst/clutter-gst-playback.h:98: warning: Field description for ClutterGstPlaybackClass::download_buffering is not used from source code comment block.
../../clutter-gst/clutter-gst-video-sink.h:91: warning: Field description for ClutterGstVideoSinkClass::new_overlays is missing in source code comment block.
...
html/clutter-gst-Video-Sink.html:199: warning: no link for: 'clutter-gst-video-sink-attach-frame' -> (<code class="function">clutter_gst_video_sink_attach_frame()</code>).
Comment 1 Chris Mayo 2015-11-28 10:51:17 UTC
Created attachment 316431 [details] [review]
fix typo in video_sink_get_frame return value
Comment 2 Chris Mayo 2015-11-28 10:51:55 UTC
Created attachment 316432 [details] [review]
add missing parameter description for content_new_with_sink
Comment 3 Chris Mayo 2015-11-28 10:52:28 UTC
Created attachment 316433 [details] [review]
don't use tmpl build step when creating
 documentation
Comment 4 Chris Mayo 2015-11-28 10:54:09 UTC
Created attachment 316434 [details] [review]
add API indices

Generate index sections by adding name-space to MKDB_OPTIONS
Comment 5 Chris Mayo 2015-11-28 10:54:55 UTC
Created attachment 316435 [details] [review]
add annotation glossary

- Replaces external links to foldoc
- Fixes build warnings e.g.:
In gtk-doc.xsl: For acronym (transfer none) no value found!
Comment 6 Chris Mayo 2015-11-28 10:55:36 UTC
Created attachment 316436 [details] [review]
add ClutterGst types
Comment 7 Chris Mayo 2015-11-28 10:56:02 UTC
Created attachment 316437 [details] [review]
add CameraManager
Comment 8 Lionel Landwerlin 2015-11-28 23:04:16 UTC
Review of attachment 316431 [details] [review]:

Looks good.
Comment 9 Lionel Landwerlin 2015-11-28 23:04:51 UTC
Review of attachment 316432 [details] [review]:

Looks good.
Comment 10 Lionel Landwerlin 2015-11-28 23:06:51 UTC
Review of attachment 316437 [details] [review]:

Looks good.
Comment 11 Lionel Landwerlin 2015-12-10 15:28:30 UTC
Review of attachment 316431 [details] [review]:

Pushed to 3.0 branch.
Comment 12 Lionel Landwerlin 2015-12-10 15:28:43 UTC
Review of attachment 316432 [details] [review]:

Pushed to 3.0 branch.
Comment 13 Lionel Landwerlin 2015-12-10 15:28:56 UTC
Review of attachment 316437 [details] [review]:

Pushed to 3.0 branch.
Comment 14 Lionel Landwerlin 2015-12-11 00:25:05 UTC
Review of attachment 316433 [details] [review]:

Pushed to 3.0 branch.
Comment 15 Lionel Landwerlin 2015-12-11 00:25:20 UTC
Review of attachment 316434 [details] [review]:

Pushed to 3.0 branch.
Comment 16 Lionel Landwerlin 2015-12-11 00:25:36 UTC
Review of attachment 316435 [details] [review]:

Pushed to 3.0 branch.
Comment 17 Lionel Landwerlin 2015-12-11 00:25:52 UTC
Review of attachment 316436 [details] [review]:

Pushed to 3.0 branch.
Comment 18 Chris Mayo 2016-02-13 16:26:19 UTC
(In reply to Lionel Landwerlin from comment #11)
> Review of attachment 316431 [details] [review] [review]:
> 
> Pushed to 3.0 branch.

Doesn't look like this one actually made it in:

fix typo in video_sink_get_frame return value
Comment 19 Chris Mayo 2016-02-13 16:28:54 UTC
(In reply to Lionel Landwerlin from comment #12)
> Review of attachment 316432 [details] [review] [review]:
> 
> Pushed to 3.0 branch.

Or this:

documentation: add missing parameter description for content_new_with_sink
Comment 20 Chris Mayo 2016-02-13 16:31:12 UTC
(In reply to Lionel Landwerlin from comment #13)
> Review of attachment 316437 [details] [review] [review]:
> 
> Pushed to 3.0 branch.

Or this:

documentation: add CameraManager
Comment 21 Lionel Landwerlin 2016-02-14 23:41:55 UTC
Sorry for that, landed on the 3.0 branch for good.