GNOME Bugzilla – Bug 758650
Use notification actions only when supported
Last modified: 2015-11-25 15:07:20 UTC
Using evolution 3.18, the calendar reminder notifications have actions or some notification server don't handle those which leads to issues (notify-osd under Unity is one example). Ideally the code would check the server capability (notify_get_server_caps()) and only add actions if those are handled
Seems like the action was added in that commit https://git.gnome.org/browse/evolution/commit/?id=c0373e7fecc4690058a91570405bd933e789d78e
Created attachment 316242 [details] [review] untested patch to fix the issue the mail-notification plugin already has code for that, that change should do the trick, I've not tested it yet but I'm going to give it a try now
Review of attachment 316242 [details] [review]: Thanks for a bug report and patch. I'll commit it, but I'm also interested to know what kind of issue the added action causes. I would expect that the libnotify will simply ignore the added action when it's not supported.
Created commit c495f5b in evo master (3.19.3+) Created commit 0ca2de1 in evo gnome-3-18 (3.18.3+)
Created attachment 316250 [details] screenshot of the notify-osd dialog Notify-osd doesn't simply ignore actions because it could lead to buggy situations, for example the notification could state "click on the button to go to the agenda" for example which would misleading if there is no button. Instead it displays those "fallback dialogs" (it looks somewhat buggy but our design team never wanted to make them better because they would then used a first class elements which they are not)