After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758634 - wayland: Use wayland-protocols for shared protocols
wayland: Use wayland-protocols for shared protocols
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-11-25 08:36 UTC by Jonas Ådahl
Modified: 2015-11-26 08:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wayland: Use pointer gestures protocol from wayland-protocols (23.16 KB, patch)
2015-11-25 08:36 UTC, Jonas Ådahl 		committed Details | Review
wayland: Use xdg shell protocol from wayland-protocols (22.46 KB, patch)
2015-11-25 08:36 UTC, Jonas Ådahl 		committed Details | Review

Description Jonas Ådahl 2015-11-25 08:36:07 UTC 
Instead of bundling our own copies of protocol XML files shared by other projects, use the ones installed by wayland-protocols.

This adds a build time dependency on wayland-protocols 1.0.

Since the unstable naming conventions formalized after introducing the initial version of pointer gestures, the pointer gestures patch is also a mass rename.
Comment 1 Jonas Ådahl 2015-11-25 08:36:20 UTC 
Created attachment 316214 [details] [review]
wayland: Use pointer gestures protocol from wayland-protocols

Instead of having our own copy of the pointer gestures XML file, use
the one installed by wayland-protocols.

Since pointer gestures is an unstable protocol, it went through the
unstable protocol naming convention changes, which is reflected in this
commit.
Comment 2 Jonas Ådahl 2015-11-25 08:36:42 UTC 
Created attachment 316215 [details] [review]
wayland: Use xdg shell protocol from wayland-protocols

Drop our own copy of the xdg shell XML file, and use the one installed
by wayland-protocols.
Comment 3 Carlos Garnacho 2015-11-25 10:41:24 UTC 
Comment on attachment 316214 [details] [review]
wayland: Use pointer gestures protocol from wayland-protocols

Looks good!
Comment 4 Carlos Garnacho 2015-11-25 10:41:43 UTC 
Comment on attachment 316215 [details] [review]
wayland: Use xdg shell protocol from wayland-protocols

Ditto
Comment 5 Jonas Ådahl 2015-11-26 08:58:22 UTC 
Attachment 316214 [details] pushed as 912e79d - wayland: Use pointer gestures protocol from wayland-protocols
Attachment 316215 [details] pushed as 1e11b55 - wayland: Use xdg shell protocol from wayland-protocols