GNOME Bugzilla – Bug 758585
Open menu dropdown is 'compressed' & unintelligible with other themes
Last modified: 2015-12-14 11:27:17 UTC
The bug has been reported on https://bugs.launchpad.net/ubuntu/+source/ubuntu-themes/+bug/1515461 see https://launchpadlibrarian.net/225877391/Screenshot%20from%202015-11-11%2021-04-22.png
Created attachment 316154 [details] [review] Define the padding in the common css
Review of attachment 316154 [details] [review]: Looks good. When overlooking at the file I saw there were some other paddings. Don't you need them as well?
that would be better but I was unsure how much you wanted there, I'm going to try to have another patch after lunch ;-)
Created attachment 316169 [details] [review] Include some extra rules in the common css Updated version, tested on Ubuntu/Unity and it looks better indeed
Review of attachment 316169 [details] [review]: See the comment. ::: gedit/resources/css/gedit-style.css @@ +50,3 @@ + +GeditStatusbar { + border-top: 1px solid @borders; afaik borders is also theme specific.
Created attachment 316171 [details] [review] Include some extra rules in the common css hum ok, it was nicer with that line but I guess that can be part of the theme... updated version without that change
Review of attachment 316171 [details] [review]: Looks good.
Review of attachment 316171 [details] [review]: https://git.gnome.org/browse/gedit/commit/?id=9da5142
thanks, commited to trunk, closing the bug
Sorry for commenting on a closed bug... I am not sure I agree with this patch The generic css is meant for stuff that is not style specific but application specific: e.g. a widget should only have a border on the left. Such style is not something related to how things should look but ay the general structure of the UI. IMHO paddings, margins etc all belong in the theme. I would be happy to accept upstream a gedit.ambience.css file (For now we can leave things as they are and not make Seb's life hard, esepcially on 3.18 but long term we need to make things right)