GNOME Bugzilla – Bug 758568
Newly-created user account does not appear if password mode is set at login
Last modified: 2016-01-05 20:35:28 UTC
* Create a new user account in g-c-c, leave password mode as 'set at login' * Log out of gnome-shell * Observe that the user is missing from the user list The problem is that when the LoginDialog object receives a user-added signal from accountsservice, the new account's password mode is not yet set, so the account is still locked and the call to _userList.addUser() returns early, so as to not show locked accounts in the user list. We probably need to connect to notify::locked to get a heads-up when the account should be added to (or removed from!) the user list.
Created attachment 316126 [details] [review] loginDialog: Reconsider user for user list when user changes Generally a user-changed operation will be uninteresting, but if the user is currently in the user list and the account changes to locked, we want to remove it from the list, or if the user is not in the list and the account changed to unlocked, we want to add it to the list. This fixes the case where a new user account created in gnome-control-center does not appear in the user list. The password mode is set in the new account immediately after it is created, but the operations are not atomic, so the login dialog considers the new user account when it is still locked and rejects it from being displayed, then immediately afterwards the account is unlocked. This commit causes the login dialog to show the account when this occurs. The containsUser() check here is not strictly necessary, but reduces spurious calls to addUser() and removeUser(), since there's no easy way to check if the locked status of the account has changed (as it's much easier to connect to one signal on the UserManager than to notify::locked on each User object).
Got a LGTM from Substitute Ray (Florian)
*** Bug 746079 has been marked as a duplicate of this bug. ***