After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758566 - NM build should find location of ping binary, instead of assuming /usr/bin/ping.
NM build should find location of ping binary, instead of assuming /usr/bin/ping.
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
1.0.x
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-11-23 23:21 UTC by Glenn Washburn
Modified: 2015-11-24 13:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] use a helper function to find out ping/ping6 binaries (1.38 KB, patch)
2015-11-24 09:25 UTC, Jiri Klimes
none Details | Review

Description Glenn Washburn 2015-11-23 23:21:10 UTC
The source src/devices/nm-device.c hardcodes the ping and ping6 binaries to /usr/bin.  Centos 6 has the binaries located in /bin.
Comment 1 Jiri Klimes 2015-11-24 09:25:57 UTC
Created attachment 316148 [details] [review]
[PATCH] use a helper function to find out ping/ping6 binaries
Comment 2 Beniamino Galvani 2015-11-24 09:36:51 UTC
LGTM
Comment 3 Thomas Haller 2015-11-24 09:56:46 UTC
LGTM
Comment 4 Jiri Klimes 2015-11-24 13:40:35 UTC
Patch committed:
master: 795a394 device: use nm_utils_find_helper() to find out ping/ping6 binary (bgo #758566)
nm-1-0: a261e9c device: use nm_utils_find_helper() to find out ping/ping6 binary (bgo #758566)