After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758471 - osdWindow: don't use custom cairo drawing
osdWindow: don't use custom cairo drawing
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2015-11-21 21:21 UTC by Cosimo Cecchi
Modified: 2016-05-21 00:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
osdWindow: don't use custom cairo drawing (3.66 KB, patch)
2015-11-21 21:21 UTC, Cosimo Cecchi
committed Details | Review
Add level bar styling (666 bytes, patch)
2015-11-21 21:22 UTC, Cosimo Cecchi
committed Details | Review

Description Cosimo Cecchi 2015-11-21 21:21:53 UTC
See attached patch. This might also fix some clipping glitches when setting a level close to zero.
Comment 1 Cosimo Cecchi 2015-11-21 21:21:56 UTC
Created attachment 316029 [details] [review]
osdWindow: don't use custom cairo drawing

We can just set the width on a regular actor inside the StBin.
Comment 2 Cosimo Cecchi 2015-11-21 21:22:19 UTC
Created attachment 316030 [details] [review]
Add level bar styling
Comment 3 Cosimo Cecchi 2016-04-03 18:31:21 UTC
Ping?
Comment 4 Florian Müllner 2016-05-20 05:27:00 UTC
Review of attachment 316029 [details] [review]:

OK
Comment 5 Florian Müllner 2016-05-20 05:27:07 UTC
Review of attachment 316030 [details] [review]:

OK
Comment 6 Cosimo Cecchi 2016-05-21 00:29:28 UTC
Comment on attachment 316030 [details] [review]
Add level bar styling

Attachment 316030 [details] pushed as 31aac7f - Add level bar styling
Comment 7 Cosimo Cecchi 2016-05-21 00:29:44 UTC
Attachment 316029 [details] pushed as 9b07ce1 - osdWindow: don't use custom cairo drawing