After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758293 - tiff: TIFFTAG_ORIENTATION values range from 1 to 8
tiff: TIFFTAG_ORIENTATION values range from 1 to 8
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: Extractor
1.6.x
Other All
: Normal normal
: ---
Assigned To: tracker-extractor
tracker-extractor
Depends on:
Blocks:
 
 
Reported: 2015-11-18 16:10 UTC by Debarshi Ray
Modified: 2015-11-18 17:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tracker-extract-tiff: Fix extraction of orientation values (1.78 KB, patch)
2015-11-18 16:13 UTC, Debarshi Ray 		none Details | Review

Description Debarshi Ray 2015-11-18 16:10:34 UTC 
The expected values for TIFFTAG_ORIENTATION are 1 to 8, not 0 to 7.

See:
https://partners.adobe.com/public/developer/en/tiff/TIFF6.pdf
http://www.awaresystems.be/imaging/tiff/tifftags/orientation.html

Also see the implementation of gdk_pixbuf_apply_embedded_orientation [1] and the handling of TIFFTAG_ORIENTATION in GdkPixbuf's TIFF loader [2].

[1] https://git.gnome.org/browse/gdk-pixbuf/tree/gdk-pixbuf/gdk-pixbuf-util.c#n291
[2] https://git.gnome.org/browse/gdk-pixbuf/tree/gdk-pixbuf/io-tiff.c#n190
Comment 1 Debarshi Ray 2015-11-18 16:13:39 UTC 
Created attachment 315840 [details] [review]
tracker-extract-tiff: Fix extraction of orientation values
Comment 2 Debarshi Ray 2015-11-18 17:38:12 UTC 
From #tracker on GIMPNet:

16:25 <rishi> garnacho: ssam2: abustany: Filed a couple of nfo:orientation      
      bugs: https://bugzilla.gnome.org/show_bug.cgi?id=758295 and               
      https://bugzilla.gnome.org/show_bug.cgi?id=758293
16:30 <garnacho> rishi, thanks :), the patches look alright to me
Comment 3 Debarshi Ray 2015-11-18 17:41:44 UTC 
Pushed to master and tracker-1.6.