GNOME Bugzilla – Bug 758259
discoverer: Add support to dump dot files
Last modified: 2016-12-25 11:54:05 UTC
Would like to dump graphs while discovering files, so that we can see which pipeline is getting auto plugged for particular files.
Created attachment 315803 [details] [review] support dumping dot files for discoverer
Makes sense to me, but you might also want to dump graphs on warning messages. And maybe instead of async-done, whenever GstDiscoverer does finish... iirc that's not only async-done but also (for sparse streams) earlier.
Created attachment 315862 [details] [review] support dumping dot files for discoverer Added handling of warning messages. In case of subtitles, DiscovererDone will be posted. And the same will be received in message handler. So for all cases when done == TRUE is posted and during warning messages dumping graphs. Please review
ping :)
Comment on attachment 315862 [details] [review] support dumping dot files for discoverer One thing that I don't like about this is that we usually only do this kind of stuff in the commandline tools and not in library API. Not sure if that's a problem here or not, I'd like to have a second opinion. Apart from that the patch is good.
I don't know, what's special about discoverer? Perhaps we should rather add some general hooks somewhere when an ERROR or ASYNC_DONE messages is posted so all pipelines benefit?
If we want to put it in something very generic (like in GstBus or something), then it would need to be another env variable.. That said, I'm quite favorable to adding patches like the above to various utility APIs that create pipeliens internally.
Well, perhaps you should push it then because for me it's WONTFIX until someone figures out something nicer / more generic :) Also, why don't we just put the GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS() in the code directly in the couple of places instead of that dump_name thing?
(In the rare case where you need to debug something discoverer related you might just as well us gst-launch with uridecodebin ! fakesink, which is pretty much what discoverer does internally, no?)
it is a little bit different from 'gst-launch with uridecodebin ! fakesink' in the sense that discover does not go through the whole file... and discover is simpler to use :) having dot file generation for discover will be a little extra help while debugging and to examine how elements are auto plugged.. But as said a more generic addition might be better instead of adding in different tools.
Olivier?
I'd say ++, unless Tim insists on something generic.
Nah, it's all good. Can still change it if we ever decide to do something generic.
commit c0a18df468a515d985cdc5dfc208d4866ded5101 Author: Vineeth TM <vineeth.tm@samsung.com> Date: Wed Nov 18 13:59:30 2015 +0900 discoverer: Add support to dump dot files Dump graphs during error/warning messages and discover is done https://bugzilla.gnome.org/show_bug.cgi?id=758259