After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758166 - librest should drop libsoup-gnome usage
librest should drop libsoup-gnome usage
Status: RESOLVED FIXED
Product: librest
Classification: Platform
Component: other
git master
Other Linux
: Normal normal
: ---
Assigned To: librest-maint
librest-maint
Depends on:
Blocks:
 
 
Reported: 2015-11-16 10:31 UTC by Pacho Ramos
Modified: 2016-07-25 14:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proxy: Remove use of libsoup-gnome (2.45 KB, patch)
2016-04-18 16:31 UTC, Christophe Fergeau 		none Details | Review

Description Pacho Ramos 2015-11-16 10:31:05 UTC 
libsoup-gnome is dead for ages and replaced by plain libsoup, maybe the requirement from librest could be dropped then 

Thanks a lot
Comment 1 Pacho Ramos 2016-03-28 14:31:03 UTC 
It looks like in some distributions simply disabled the libsoup-gnome support in favor of using a newer libsoup version:
https://www.mail-archive.com/frugalware-git@frugalware.org/msg145625.html
Comment 2 Pacho Ramos 2016-03-28 14:33:04 UTC 
And I see others like Fedora and Arch are neither requiring libsoup-gnome as they seem to not enable that gnome optional support
Comment 3 Christophe Fergeau 2016-04-18 16:31:57 UTC 
Created attachment 326283 [details] [review]
proxy: Remove use of libsoup-gnome

It has been deprecated for a long while, and we were only using it for
proxy support. However, libsoup has had a SoupProxyResolverDefault
replacement since libsoup 2.34 (released in April 2011).

This commit switches to using SoupProxyResolverDefault and drops the
GNOME specific code.
Comment 4 Christophe Fergeau 2016-04-18 16:32:29 UTC 
This patch should achieve that.
Comment 5 Christophe Fergeau 2016-04-19 12:41:31 UTC 
Ah, very similar patch in bug#712747 :
https://bugzilla.gnome.org/review?bug=712747&attachment=260317
Comment 6 Timm Bäder 2016-07-25 14:29:57 UTC 
We can close this since 8f904a8e2bb38a7bf72245cdf2f1ecad17e9a720 landed, right?
Comment 7 Christophe Fergeau 2016-07-25 14:43:34 UTC 
Yes, thanks!